Closed Bug 412216 Opened 14 years ago Closed 14 years ago

xpcshell tests (make check) don't work on Solaris

Categories

(Testing :: XPCShell Harness, defect)

x86
OpenSolaris
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla1.9

People

(Reporter: Dolske, Assigned: Dolske)

References

Details

Attachments

(1 file)

$ gmake -C ... check
...
/export/home/dolske/ff/ff-debug/mozilla/tools/test-harness/xpcshell-simple/test_all.sh: XPCOM_DEBUG_BREAK=stack-and-abort: is not an identifier
...

test_all.sh and test_one.sh are Bourne shell scripts, you can't "export FOO=bar" in one shot -- the variable assignment and exporting should happen in different steps. Solaris is picky about this, I guess other OSen have more permissive implementations or something.

Anyway, trivial fix. A skim though mxr for "export" in *.sh files shows this to be the only instance of the problem.
Attachment #296881 - Flags: review?(rcampbell)
Blocks: 346922
No longer blocks: 353010
Comment on attachment 296881 [details] [diff] [review]
Patch v.1 for review

this looks reasonable to me. I don't have a solaris image here to test on, but we should notice pretty quickly if this breaks the tree.
Attachment #296881 - Flags: review?(rcampbell) → review+
Assignee: nobody → dolske
Checked in.

Checking in tools/test-harness/xpcshell-simple/test_all.sh;
/cvsroot/mozilla/tools/test-harness/xpcshell-simple/test_all.sh,v  <--  test_all.sh
new revision: 1.13; previous revision: 1.12
done
Checking in tools/test-harness/xpcshell-simple/test_one.sh;
/cvsroot/mozilla/tools/test-harness/xpcshell-simple/test_one.sh,v  <--  test_one.sh
new revision: 1.5; previous revision: 1.4
done
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9 M11
Component: Testing → TUnit
Product: Core → Testing
QA Contact: testing → tunit
Target Milestone: mozilla1.9beta3 → mozilla1.9
You need to log in before you can comment on or make changes to this bug.