412216 - xpcshell tests (make check) don't work on Solaris

Status: RESOLVED FIXED

(Testing :: XPCShell Harness, defect)

Description

[Justin Dolske [:Dolske]]

Attachment: Patch v.1 for review

$ gmake -C ... check
...
/export/home/dolske/ff/ff-debug/mozilla/tools/test-harness/xpcshell-simple/test_all.sh: XPCOM_DEBUG_BREAK=stack-and-abort: is not an identifier
...

test_all.sh and test_one.sh are Bourne shell scripts, you can't "export FOO=bar" in one shot -- the variable assignment and exporting should happen in different steps. Solaris is picky about this, I guess other OSen have more permissive implementations or something.

Anyway, trivial fix. A skim though mxr for "export" in *.sh files shows this to be the only instance of the problem.

Comment 1

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 296881 [details] [diff] [review]
Patch v.1 for review

this looks reasonable to me. I don't have a solaris image here to test on, but we should notice pretty quickly if this breaks the tree.

Comment 2

[Justin Dolske [:Dolske]]

Checked in.

Checking in tools/test-harness/xpcshell-simple/test_all.sh;
/cvsroot/mozilla/tools/test-harness/xpcshell-simple/test_all.sh,v  <--  test_all.sh
new revision: 1.13; previous revision: 1.12
done
Checking in tools/test-harness/xpcshell-simple/test_one.sh;
/cvsroot/mozilla/tools/test-harness/xpcshell-simple/test_one.sh,v  <--  test_one.sh
new revision: 1.5; previous revision: 1.4
done