412218 - if the call to UpdateBookmarkHashOnRemove() from RemoveItem() fails to remove the bookmark from the hash table (because the bookmark is in the db), we should return gracefully and immediately

Status: RESOLVED WONTFIX

(Firefox :: Bookmarks & History, defect)

Description

[Seth Spitzer]

if the call to UpdateBookmarkHashOnRemove() from RemoveItem() fails to remove the bookmark from the hash table (because the bookmark is in the db), we should return gracefully and immediately

from my patch:

>+  // XXX is this too expensive when updating livemarks?
>+  // UpdateBookmarkHashOnRemove() does a sanity check using
>+  // IsBookmarkedInDatabase(),  so it might not have actually
>+  // removed the bookmark.  should we have a boolean out param
>+  // for if we actually removed it, and use that to decide if we call
>+  // UpdateFrecency() and the rest of this code?

we should add a boolean out param to UpdateBookmarkHashOnRemove(), and if it fails, return to avoid calling UpdateFrecency() and also the other, existing work we do in RemoveItem() after we call UpdateBookmarkHashOnRemove()

this could be fixed separate from #394038

note, I'm not sure if UpdateBookmarkHashOnRemove() fails often, if ever, so this is low priority.

Comment 1

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv

Comment 2

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

wontfix per bug 542943.