Closed Bug 412239 Opened 14 years ago Closed 14 years ago

Warnings in nsSVGPathElement.cpp

Categories

(Core :: SVG, defect)

All
Linux
defect
Not set
trivial

Tracking

()

RESOLVED FIXED
mozilla1.9beta3

People

(Reporter: tim_tim2000, Assigned: tim_tim2000)

Details

Attachments

(1 file)

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; ru; rv:1.8.1.11) Gecko/20071127 Firefox/2.0.0.11
Build Identifier: 

In Firefox 3.0b3pre, 6 warnings in nsSVGPathElement.cpp;
nsSVGPathElement.cpp: In member function ‘virtual void
nsSVGPathElement::GetMarkPoints(nsTArray<nsSVGMark>*)’:
nsSVGPathElement.cpp:542: warning: ‘endAngle’ may be used uninitialized in
this function
nsSVGPathElement.cpp:542: warning: ‘startAngle’ may be used uninitialized
in this function
nsSVGPathElement.cpp:540: warning: ‘pathIndex’ may be used uninitialized in
this function
nsSVGPathElement.cpp:539: warning: ‘pathAngle’ may be used uninitialized in
this function
nsSVGPathElement.cpp:538: warning: ‘py’ may be used uninitialized in this
function
nsSVGPathElement.cpp:538: warning: ‘px’ may be used uninitialized in this
function

Linux kernel version: 2.6.23.12
gcc version: 4.1.3
Ubuntu 7.10

Reproducible: Always

Steps to Reproduce:
1. Download Firefox source code.
2. Attempt to compile.

Actual Results:  
See warnings.

Expected Results:  
See no warnings.

Cross-post from https://bugzilla.mozilla-russia.org/show_bug.cgi?id=365 at the bug owner's request.
Attached patch PatchSplinter Review
Cross-posting the bug and the patch from Mozilla.ru's bugzilla.
Attachment #296909 - Flags: review?
Timur: when you ask for review you need to specify who you are asking to review the patch. http://www.mozilla.org/hacking/life-cycle.html has more info.

I believe one of jwatt@jwatt.org, longsonr@gmail.com or tor@acm.org (Module owner) would be appropriate.
Attachment #296909 - Flags: review? → review?(alex)
Attachment #296909 - Flags: superreview?(tor)
Attachment #296909 - Flags: review?(tor)
Attachment #296909 - Flags: review?(alex)
Assignee: nobody → tim_tim2000
Attachment #296909 - Flags: superreview?(tor)
Attachment #296909 - Flags: superreview+
Attachment #296909 - Flags: review?(tor)
Attachment #296909 - Flags: review+
Keywords: checkin-needed
Keywords: checkin-needed
Attachment #296909 - Flags: approval1.9?
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Version: unspecified → Trunk
Attachment #296909 - Flags: approval1.9? → approval1.9+
Keywords: checkin-needed
Checking in content/svg/content/src/nsSVGPathElement.cpp;
/cvsroot/mozilla/content/svg/content/src/nsSVGPathElement.cpp,v  <--  nsSVGPathElement.cpp
new revision: 1.41; previous revision: 1.40
done
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9 M11
You need to log in before you can comment on or make changes to this bug.