412346 - Firefox Extension Manager leaks with nsGlobalWindows when QuickTranslator Extension is installed

Status: RESOLVED FIXED

(Core :: General, defect)

Description

[Carsten Book [:Tomcat]]

Attachment: leak log

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b3pre) Gecko/2008011415
Minefield/3.0b3pre


Steps to reproduce:
New Profile
Add the Extension Quick TransLator (https://addons.mozilla.org/en-US/firefox/addon/5641)
Make sure the Extension is successfully installed (you will see some addional icons in the status bar)
Go to the Extension Manager
Close the Extension Manager
Leak !

nsStringStats
 => mAllocCount:          24747
 => mReallocCount:         4104
 => mFreeCount:           24049  --  LEAKED 698 !!!
 => mShareCount:          22817
 => mAdoptCount:           2324
 => mAdoptFreeCount:       2307  --  LEAKED 17 !!!

Comment 1

[Dave Townsend [:mossop]]

Seem to be a substantial number of extensions leaking in this way from your testing. Are you testing this on the first Firefox startup after installing.

Does it still leak in the same way on the second startup?

Does it always leak on the first startup if you don't open the extension manager window?

Comment 2

[Carsten Book [:Tomcat]]

(In reply to comment #1)
> Seem to be a substantial number of extensions leaking in this way from your
> testing. Are you testing this on the first Firefox startup after installing.
> 

Yeah, i do run a normal test after the first installation, to make sure that the Extension does not leak in General.

As example the testing steps are:

I do install the Extension -> After the Firefox restart i close Firefox to make sure the extension does not leak in general -> if there is no leak (like in this case), i open the extension manager, close the Extension Manager Window (to avoid Bug 412124) and then i quit firefox. And check the leak log.

> Does it still leak in the same way on the second startup?
> 
Yes, the Extension Manager (and this happen only when you open the Extension Maanger. You don't need to do anything, open and close the EM is enough :-(

> Does it always leak on the first startup if you don't open the extension
> manager window?
> 

No, there is no leak until i visit the Extension Manager when this extension is installed

Comment 3

[Carsten Book [:Tomcat]]

not leaking after the fix from bug 412491 went in and using Mozilla/5.0
(Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9b3pre) Gecko/2008012105
Firefox/3.0b3pre

-> Fixed