crash in gfxPlatformGtk::CreateOffscreenSurface() when using xpcshell

RESOLVED FIXED

Status

Core Graveyard
GFX: Gtk
RESOLVED FIXED
10 years ago
9 years ago

People

(Reporter: Dolske, Assigned: Dolske)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

10 years ago
Created attachment 297100 [details] [diff] [review]
Patch v.1 for review

Bug 389273 adds some image manipulation code (imgITools) and unit tests. The code works fine when invoked via the browser code using it (Win/Mac/Linux), and the unit tests pass on Win/Mac. But the unit tests crash on Linux.

Attachment 296898 [details] has the full stack, but the upshot is that we're crashing because there's no gdk display. With a null check here to return an error, the unit tests pass.
Attachment #297100 - Flags: review?(pavlov)
(Assignee)

Updated

10 years ago
Assignee: nobody → dolske

Updated

10 years ago
Attachment #297100 - Flags: review?(pavlov) → review+
(Assignee)

Updated

10 years ago
Attachment #297100 - Flags: approval1.9?

Updated

10 years ago
Attachment #297100 - Flags: approval1.9? → approval1.9+
(Assignee)

Comment 1

10 years ago
Checking in gfx/thebes/src/gfxPlatformGtk.cpp;
/cvsroot/mozilla/gfx/thebes/src/gfxPlatformGtk.cpp,v  <--  gfxPlatformGtk.cpp
new revision: 1.32; previous revision: 1.31
done
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.