Closed Bug 412519 Opened 14 years ago Closed 14 years ago

libdbusservice.so is missing from package

Categories

(Firefox Build System :: General, defect)

x86
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla3 beta3

People

(Reporter: wolfiR, Assigned: wolfiR)

Details

Attachments

(2 files)

components/libdbusservice.so is missing from the Linux package.
Flags: blocking-firefox3?
Flags: blocking-firefox3?
Product: Firefox → Toolkit
QA Contact: build.config → build-config
Flags: blocking1.9?
Should be added to browser/installer/unix/packages-static, I guess?
Flags: blocking1.9?
Product: Toolkit → Firefox
QA Contact: build-config → build.config
Attached patch patchSplinter Review
patch to add the component.
It seems the file list is not really sorted so I just added it to the end of that section.
Flags: blocking-firefox3?
Assignee: nobody → mozilla
Comment on attachment 297265 [details] [diff] [review]
patch

Not exactly an idea if that's build config or browser component. So just guessing the reviewer
Attachment #297265 - Flags: review?(gavin.sharp)
Attachment #297265 - Flags: review?(gavin.sharp) → review+
Attachment #297265 - Flags: approval1.9?
Attachment #297265 - Flags: approval1.9? → approval1.9+
checked in
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
reset blocking request -> not needed anymore
Flags: blocking-firefox3?
I think SeaMonkey probably needs this as well.
Probably, but I wonder how the mail component would interact with it.
In mailnews going offline would probably try to sync/download messages while it would fail since the connection is gone at that point already.
So the component as it is might need to be revised for that?
I think we already handle online/offline signals on other OSes, and on self-built Linux installations.
So, all in all, please add this to SeaMonkey and Thunderbird as well, AFAIK we all can deal with those network messages, and if not yet, we should do so anyways.
Attached patch SeaMonkey patchSplinter Review
Not sure if this is the right spot...
Attachment #297690 - Flags: superreview?(neil)
Attachment #297690 - Flags: review?(kairo)
(In reply to comment #9)
> So, all in all, please add this to SeaMonkey and Thunderbird as well

I don't see a unix-specific packages file for Thunderbird. I only see mail/installer/windows/packages-static...
Looks like TB is currently packaging everything in dist/bin/ on non-Windows so nothing to do here.
Attachment #297690 - Flags: superreview?(neil) → superreview+
Comment on attachment 297690 [details] [diff] [review]
SeaMonkey patch

Thanks. As long as it's within [browser], it can only be "the right spot" in terms of the resulting package ;-)
r=me
Attachment #297690 - Flags: review?(kairo) → review+
Checking in suite/installer/unix/packages;
/cvsroot/mozilla/suite/installer/unix/packages,v  <--  packages
new revision: 1.10; previous revision: 1.9
done
Target Milestone: --- → Firefox 3 M11
Component: Build Config → General
Product: Firefox → Firefox Build System
Target Milestone: Firefox 3 beta3 → mozilla3 beta3
You need to log in before you can comment on or make changes to this bug.