port tamarin vm to 64 bit windows and mac osx

VERIFIED FIXED

Status

Tamarin
Virtual Machine
--
enhancement
VERIFIED FIXED
11 years ago
9 years ago

People

(Reporter: Chris Peyer, Assigned: Rob Winchell)

Tracking

Details

Attachments

(1 attachment)

(Reporter)

Description

11 years ago
- port tamarin vm to 64 bit windows and mac
- verify vm compliance tests pass on 64 os
- when work is complete we can setup automated build and test
 
 
Transferred Comments:

Dan Schaffer - Thu Nov 15 09:33:11 CST 2007
open to Rob for flash player 10.
(Assignee)

Comment 1

11 years ago
Assigned to me.
Status: NEW → ASSIGNED
(Assignee)

Comment 2

11 years ago
Created attachment 298716 [details] [diff] [review]
Proposed changes for Windows x64 support
Assignee: nobody → rwinchel
Attachment #298716 - Flags: review?
(Assignee)

Updated

11 years ago
Attachment #298716 - Flags: review?(rreitmai)
Attachment #298716 - Flags: review?(edwsmith)

Comment 3

11 years ago
Comment on attachment 298716 [details] [diff] [review]
Proposed changes for Windows x64 support

Lots of (int) casting going on!

Besides here are a few more specific comments;

AmdAssembler64 Lines 664-674   - avmasert(0) still in there.  
 Lines 871-916    - verbose turned off all the time?
CodegenMIR.cpp
 Lines 7394-7400   - what happened to IA_32 case?
 Lines 8467-8481  - MOV() macro not surrounded by {}  might be dangerous.
Interpreter.cpp
 Lines 244-249  - motivation for moving decimalParam wasn't clear
Attachment #298716 - Flags: review?(rreitmai) → review+
(Assignee)

Updated

10 years ago
Attachment #298716 - Flags: review?(wsharp)

Updated

10 years ago
Attachment #298716 - Flags: review?(wsharp) → review+

Updated

10 years ago
Attachment #298716 - Flags: review?(edwsmith) → review+
(Assignee)

Updated

10 years ago
Attachment #298716 - Flags: review?

Comment 4

10 years ago
is this still relevant or should it be closed?

Comment 5

10 years ago
close it, imo

Comment 6

10 years ago
resolved, current redux is 64b clean.
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED

Comment 7

10 years ago
actually I don't think it's 100% clean on Mac, is it? (probably could be with little effort tho)

Updated

9 years ago
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.