Closed
Bug 412689
Opened 17 years ago
Closed 17 years ago
var Ci = Ci in function initialises Ci to undefined
Categories
(Toolkit :: Safe Browsing, defect, P1)
Toolkit
Safe Browsing
Tracking
()
RESOLVED
FIXED
Firefox 3 beta3
People
(Reporter: brendan, Assigned: Gavin)
References
()
Details
Attachments
(1 file)
|
924 bytes,
patch
|
tony
:
review+
|
Details | Diff | Splinter Review |
http://lxr.mozilla.org/mozilla/source/toolkit/components/url-classifier/content/moz/preferences.js#257 (bug URL). Sorry if misfiled. /be
|
Reporter | |
Updated•17 years ago
|
Flags: blocking-firefox3+
|
Assignee | |
Comment 1•17 years ago
|
||
The obvious fix, just remove the line. I imagine it was caused by a global search and replace. I wonder if this contributed to bug 386665? Failing to QI to nsISupportsWeakReference might have caused that, though http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/toolkit/components/url-classifier/content/moz/preferences.js&rev=1.8&mark=194#184 (which appears to be the only place one of these is instantiated) makes me think it wouldn't matter. (I'm also surprised this wasn't noticed in timeless' bug 371729 - people must not read his comment 0s ;)
|
|
Assignee | |
Updated•17 years ago
|
Priority: -- → P1
Target Milestone: --- → Firefox 3 M11
Version: unspecified → Trunk
|
||
Comment 2•17 years ago
|
||
Comment on attachment 297459 [details] [diff] [review] patch thanks!
Attachment #297459 -
Flags: review?(tony) → review+
|
|
Assignee | |
Comment 3•17 years ago
|
||
mozilla/toolkit/components/url-classifier/content/moz/preferences.js 1.9
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
|
||
Updated•10 years ago
|
Product: Firefox → Toolkit
You need to log in
before you can comment on or make changes to this bug.
Description
•