Closed Bug 412689 Opened 12 years ago Closed 12 years ago

var Ci = Ci in function initialises Ci to undefined

Categories

(Toolkit :: Safe Browsing, defect, P1)

defect

Tracking

()

RESOLVED FIXED
Firefox 3 beta3

People

(Reporter: brendan, Assigned: Gavin)

References

()

Details

Attachments

(1 file)

Flags: blocking-firefox3+
Attached patch patchSplinter Review
The obvious fix, just remove the line. I imagine it was caused by a global search and replace. I wonder if this contributed to bug 386665? Failing to QI to nsISupportsWeakReference might have caused that, though http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/toolkit/components/url-classifier/content/moz/preferences.js&rev=1.8&mark=194#184  (which appears to be the only place one of these is instantiated) makes me think it wouldn't matter.

(I'm also surprised this wasn't noticed in timeless' bug 371729 - people must not read his comment 0s ;)
Assignee: nobody → gavin.sharp
Status: NEW → ASSIGNED
Attachment #297459 - Flags: review?(tony)
Priority: -- → P1
Target Milestone: --- → Firefox 3 M11
Version: unspecified → Trunk
Comment on attachment 297459 [details] [diff] [review]
patch

thanks!
Attachment #297459 - Flags: review?(tony) → review+
mozilla/toolkit/components/url-classifier/content/moz/preferences.js 	1.9
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.