412719 - use -moz-cellhighlight* system color for selected items in non focused lists

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, defect)

Description

[Teune van Steeg]

Attachment: patch

Since -moz-cellhighlight is the correct color for selected cells in non focused trees / lists on Linux, (and -moz-cellhighlighttext the correct text color), this should be used for those elements and resembling elements in Mozilla too.

For Win32 nothing changes: -moz-cellhighlight* is the same color as -moz-Dialog*, but this makes it more distinguishable, and it will be easier to implement a new color for this if it is ever needed. What's more is that richlistbox.css from winstripe is still shared with gnomestripe.

For Mac I don't know what to do: currently for trees and lists -moz-mac-secundairyhighlight is used, but not for richlistboxes. Note that currently -moz-cellhighlight* is the same as -moz-Dialog*, but with the patch for bug 412281 in its current state -moz-cellhighlight will be the same as -moz-mac-secundairyhighlight.

Comment 1

[Neil Deakin]

Comment on attachment 297479 [details] [diff] [review]
patch

Looks OK, except for the one in gnomestripe/global/listbox.css :

+  color: -moz-cellhighlight;

should be -moz-cellhighlighttext

Comment 2

[Teune van Steeg]

Attachment: patch (v1.1)

Fixed nit.

Comment 3

[Teune van Steeg]

Comment on attachment 298158 [details] [diff] [review]
patch (v1.1)

removing request for approval until things at bug 413272 are sorted out.

Comment 4

[Teune van Steeg]

Comment on attachment 298158 [details] [diff] [review]
patch (v1.1)

Bug 413272 does not affect this patch: Requesting approval for a patch which makes selected items in unfocused trees / lists look better on Linux, by using an existing CSS system color, created for this purpose.

Comment 5

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 298158 [details] [diff] [review]
patch (v1.1)

a=beltzner for 1.9, yay, look'n'feel

Comment 6

[Reed Loden [:reed]]

Checking in toolkit/themes/gnomestripe/global/listbox.css;
/cvsroot/mozilla/toolkit/themes/gnomestripe/global/listbox.css,v  <--  listbox.css
new revision: 1.5; previous revision: 1.4
done
Checking in toolkit/themes/gnomestripe/global/tree.css;
/cvsroot/mozilla/toolkit/themes/gnomestripe/global/tree.css,v  <--  tree.css
new revision: 1.10; previous revision: 1.9
done
Checking in toolkit/themes/gnomestripe/mozapps/extensions/extensions.css;
/cvsroot/mozilla/toolkit/themes/gnomestripe/mozapps/extensions/extensions.css,v  <--  extensions.css
new revision: 1.2; previous revision: 1.1
done
Checking in toolkit/themes/winstripe/global/listbox.css;
/cvsroot/mozilla/toolkit/themes/winstripe/global/listbox.css,v  <--  listbox.css
new revision: 1.10; previous revision: 1.9
done
Checking in toolkit/themes/winstripe/global/richlistbox.css;
/cvsroot/mozilla/toolkit/themes/winstripe/global/richlistbox.css,v  <--  richlistbox.css
new revision: 1.3; previous revision: 1.2
done
Checking in toolkit/themes/winstripe/global/tree.css;
/cvsroot/mozilla/toolkit/themes/winstripe/global/tree.css,v  <--  tree.css
new revision: 1.13; previous revision: 1.12
done
Checking in toolkit/themes/winstripe/mozapps/extensions/extensions.css;
/cvsroot/mozilla/toolkit/themes/winstripe/mozapps/extensions/extensions.css,v  <--  extensions.css
new revision: 1.37; previous revision: 1.36
done