Closed
Bug 412739
Opened 16 years ago
Closed 16 years ago
"Next Week" events in Today pane are really "Soon" events
Categories
(Calendar :: Lightning Only, defect)
Calendar
Lightning Only
Tracking
(Not tracked)
VERIFIED
FIXED
0.8
People
(Reporter: wabik, Assigned: berend.cornelius09)
Details
Attachments
(1 obsolete file)
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; pl; rv:1.8.1.11) Gecko/20071127 Firefox/2.0.0.11 Build Identifier: Lightning 0.8pre build 2008010303 Next week events are in fact not next week but as it was in 0.7 Soon events! Reproducible: Always Steps to Reproduce: 1.Always present 2. 3.
Comment 1•16 years ago
|
||
Confirming. The events shown under Next Week in the Today pane are actually the events that occur beyond tomorrow. Either the label or the functionality should be changed.
Severity: major → minor
Status: UNCONFIRMED → NEW
Ever confirmed: true
OS: Windows XP → All
Summary: Next week events are Soon events → "Next Week" events in Today pane are really "Soon" events
Updated•16 years ago
|
Hardware: PC → All
Comment 2•16 years ago
|
||
Nominating for blocking-calendar0.8. This is a major UI problem, also observed on our last testday.
Flags: blocking-calendar0.8?
Updated•16 years ago
|
Flags: blocking-calendar0.8? → blocking-calendar0.8+
Assignee | ||
Updated•16 years ago
|
Assignee: nobody → Berend.Cornelius
Assignee | ||
Comment 3•16 years ago
|
||
This patch requires a late-l10n string.
Attachment #301500 -
Flags: review?(philipp)
Comment 4•16 years ago
|
||
Comment on attachment 301500 [details] [diff] [review] patch -v. #1 >-<!ENTITY calendar.nextweek.button.label "Next Week"> >+<!ENTITY calendar.nextweek.button.label "Soon"> You can't keep the same entity name. This is a major change in the meaning. In many addition l10n teams won't pick up the change if the entity name doesn't change. As the result the issue would still exist in many translations. Is it possible to use the existing string agendaSoon from lightning.properties?
Updated•16 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Comment 5•16 years ago
|
||
In reply to comment #4: I can see your point and I admit I also was hesitating to use the entity. I was using and changing it because I introduced it just for the agenda-pane (bug 389854) together with its preceeding entities. You are right and I was also aware that I could use the string from lightning.properties but it would make my sourcecode very unclear in that context.
Comment 6•16 years ago
|
||
Comment on attachment 301500 [details] [diff] [review] patch -v. #1 >-<!ENTITY calendar.nextweek.button.label "Next Week"> >+<!ENTITY calendar.nextweek.button.label "Soon"> As ssitter noted, please change the entity name. Since we need (admittedly pretty late) l10n anyway, go ahead and use entities. r=philipp
Attachment #301500 -
Flags: review?(philipp) → review+
Assignee | ||
Comment 7•16 years ago
|
||
This issue is fixed. The patch attached is no longer directly related to this issue.
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Comment 8•16 years ago
|
||
checke in latest nightly build -> task is fixed and verified.
Status: RESOLVED → VERIFIED
Updated•16 years ago
|
Attachment #301500 -
Attachment is obsolete: true
Updated•16 years ago
|
Target Milestone: --- → 0.8
You need to log in
before you can comment on or make changes to this bug.
Description
•