41275 - ENDER-LITE, typing in subject line of mail causes entire page to repaint

Status: VERIFIED FIXED

(Core :: Layout, defect, P1)

Description

[mjudge]

this leads to typing being VERY slow in subject line of mail. this is NOT 
limited to this example however. i will add an attachment with another example.
please mark this beta2 blocker since i cannot turn on ender-lite until this is 
fixed. and the later i turn it on the less chance to catch any other problems.

blocking bug#34896

Comment 1

[mjudge]

Attachment: test case of alot of text areas/input fields

Comment 2

[mjudge]

this is only with the ENDER_LITE flag turned on.

Comment 3

[buster]

will look at right away

Comment 4

[leger]

Putting on [nsbeta2+] radar for beta2 fix. 

Comment 5

[buster]

cc'ing hyatt and eric.

Initial investigation:
1. I set a breakpoint in nsViewManager2::UpdateView(). Disable it for now.
2. Open a mail compose window, type a character in the subject (just to seed the 
text field, this is just a convenience.)
3. Enable the breakpoint.
4. Type a second character.
5. The core layout code does it's normal 2 invalidates:  one for the text frame 
and one for the block containing the text frame.  These are limited to the size 
of the text control.
6. I then see about 50 more invalidate calls of all sizes, some very large 
(probably the whole window) all generated by box layout.  I don't think core 
layout is doing anything to cause this to happen.
7. By contrast, when you type in the body of the message, you only get two 
invalidates, both as described above, limited to the size of the line you're 
typing on.

Comment 6

[buster]

based on email from eric, assigning to him

Comment 7

[Eric Vaughan]

I have fixed typing in ender everywhere but 2 places. It still doesn't 
completely work when typing in the subject line because of some weird stuff 
trees are doing. But I'm assuming this will be fixed with the table on grid fix 
hyatt is doing. The other case of flashing in HTML is being resubmited as a 
different bug by mjudge.

Comment 8

[Peter Trudelle]

Dave, can you confirm Eric's assumption?

Comment 9

[David Hyatt]

fixed.

Comment 10

[Chris Petersen]

Using the test case supplied, I was able to type at real time in the various text 
field. Slow performance was not a issue for me. Marking verified fixed in the 
June 26th builds.