Thanks to Reed for making me aware of the following: /home/reed/mozilla/builds/mozilla/security/manager/ssl/src/nsIdentityChecking.cpp: In member function ‘void nsNSSComponent::CleanupIdentityInfo()’: /home/reed/mozilla/builds/mozilla/security/manager/ssl/src/nsIdentityChecking.cpp:693: warning: ‘i’ may be used uninitialized Yes, this is a bad bug, although luckily, this code is only used for cleanup in testing. I am surprised. The Linux compiler does not warn about this!!!!!!
Created attachment 297554 [details] [diff] [review] Patch v1 Requesting review and approval on obvious correctness fix.
(In reply to comment #0) > The Linux compiler does not warn about this!!!!!! Really? Then I must be dreaming, as that's how I found it. ;) $ g++ -v Using built-in specs. Target: i486-linux-gnu Configured with: ../src/configure -v --enable-languages=c,c++,fortran,objc,obj-c++,treelang --prefix=/usr --enable-shared --with-system-zlib --libexecdir=/usr/lib --without-included-gettext --enable-threads=posix --enable-nls --with-gxx-include-dir=/usr/include/c++/4.1.3 --program-suffix=-4.1 --enable-__cxa_atexit --enable-clocale=gnu --enable-libstdcxx-debug --enable-mpfr --enable-checking=release i486-linux-gnu Thread model: posix gcc version 4.1.3 20070929 (prerelease) (Ubuntu 4.1.2-16ubuntu2)
Comment on attachment 297554 [details] [diff] [review] Patch v1 yea - please land once reviewed.
Attachment #297554 - Flags: approval1.9? → approval1.9+
Comment on attachment 297554 [details] [diff] [review] Patch v1 r+ rrelyea
Attachment #297554 - Flags: review?(rrelyea) → review+
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.