integrate buildbot config file tester w/ buildbot

RESOLVED FIXED

Status

Release Engineering
General
P2
normal
RESOLVED FIXED
11 years ago
5 years ago

People

(Reporter: bhearsum, Assigned: bhearsum)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 1 obsolete attachment)

(Assignee)

Description

11 years ago
Created attachment 297570 [details] [diff] [review]
integrate config file tester

This patch integrates a config file tester into Buildbot. It makes it accessible through 'buildbot checkconfig'. I've already posted this on buildbot.net in ticket#37: http://buildbot.net/trac/ticket/37
(Assignee)

Updated

11 years ago
Attachment #297570 - Flags: review?(rcampbell)
(Assignee)

Comment 1

11 years ago
Created attachment 297762 [details] [diff] [review]
[checked in] fix indentation error

I finally ran the unit tests on this patch and discovered an indentation error. All of the unit tests pass now.
Attachment #297570 - Attachment is obsolete: true
Attachment #297762 - Flags: review?(rcampbell)
Attachment #297570 - Flags: review?(rcampbell)
(Assignee)

Updated

11 years ago
Priority: -- → P2
Comment on attachment 297762 [details] [diff] [review]
[checked in] fix indentation error

looks good.
Attachment #297762 - Flags: review?(rcampbell) → review+
(Assignee)

Comment 3

11 years ago
Comment on attachment 297762 [details] [diff] [review]
[checked in] fix indentation error

Checking in buildbot/scripts/runner.py;
/cvsroot/mozilla/tools/buildbot/buildbot/scripts/runner.py,v  <--  runner.py
new revision: 1.2; previous revision: 1.1
done
Attachment #297762 - Attachment description: fix indentation error → [checked in] fix indentation error
(Assignee)

Updated

11 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
(Assignee)

Comment 4

11 years ago
I've just noticed that this patch _requires_ Python 2.5 ('finally' doesn't exist in previous versions). I'll have a patch up soon that supports at least Python 2.4 and Python 2.5.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 5

11 years ago
Created attachment 300013 [details] [diff] [review]
[checked in] call chdir/rmtree in except and outside
Attachment #300013 - Flags: review?(rcampbell)
Attachment #300013 - Flags: review?(rcampbell) → review+
(Assignee)

Comment 6

11 years ago
Comment on attachment 300013 [details] [diff] [review]
[checked in] call chdir/rmtree in except and outside

Checking in buildbot/scripts/runner.py;
/cvsroot/mozilla/tools/buildbot/buildbot/scripts/runner.py,v  <--  runner.py
new revision: 1.2.2.1; previous revision: 1.2
done
Attachment #300013 - Attachment description: call chdir/rmtree in except and outside → [checked in] call chdir/rmtree in except and outside
(Assignee)

Updated

11 years ago
Status: REOPENED → RESOLVED
Last Resolved: 11 years ago11 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.