Closed
Bug 412807
Opened 16 years ago
Closed 16 years ago
integrate buildbot config file tester w/ buildbot
Categories
(Release Engineering :: General, defect, P2)
Release Engineering
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: bhearsum, Assigned: bhearsum)
Details
Attachments
(2 files, 1 obsolete file)
3.29 KB,
patch
|
rcampbell
:
review+
|
Details | Diff | Splinter Review |
697 bytes,
patch
|
rcampbell
:
review+
|
Details | Diff | Splinter Review |
This patch integrates a config file tester into Buildbot. It makes it accessible through 'buildbot checkconfig'. I've already posted this on buildbot.net in ticket#37: http://buildbot.net/trac/ticket/37
Assignee | ||
Updated•16 years ago
|
Attachment #297570 -
Flags: review?(rcampbell)
Assignee | ||
Comment 1•16 years ago
|
||
I finally ran the unit tests on this patch and discovered an indentation error. All of the unit tests pass now.
Attachment #297570 -
Attachment is obsolete: true
Attachment #297762 -
Flags: review?(rcampbell)
Attachment #297570 -
Flags: review?(rcampbell)
Assignee | ||
Updated•16 years ago
|
Priority: -- → P2
Comment 2•16 years ago
|
||
Comment on attachment 297762 [details] [diff] [review] [checked in] fix indentation error looks good.
Attachment #297762 -
Flags: review?(rcampbell) → review+
Assignee | ||
Comment 3•16 years ago
|
||
Comment on attachment 297762 [details] [diff] [review] [checked in] fix indentation error Checking in buildbot/scripts/runner.py; /cvsroot/mozilla/tools/buildbot/buildbot/scripts/runner.py,v <-- runner.py new revision: 1.2; previous revision: 1.1 done
Attachment #297762 -
Attachment description: fix indentation error → [checked in] fix indentation error
Assignee | ||
Updated•16 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 4•16 years ago
|
||
I've just noticed that this patch _requires_ Python 2.5 ('finally' doesn't exist in previous versions). I'll have a patch up soon that supports at least Python 2.4 and Python 2.5.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Comment 5•16 years ago
|
||
Attachment #300013 -
Flags: review?(rcampbell)
Updated•16 years ago
|
Attachment #300013 -
Flags: review?(rcampbell) → review+
Assignee | ||
Comment 6•16 years ago
|
||
Comment on attachment 300013 [details] [diff] [review] [checked in] call chdir/rmtree in except and outside Checking in buildbot/scripts/runner.py; /cvsroot/mozilla/tools/buildbot/buildbot/scripts/runner.py,v <-- runner.py new revision: 1.2.2.1; previous revision: 1.2 done
Attachment #300013 -
Attachment description: call chdir/rmtree in except and outside → [checked in] call chdir/rmtree in except and outside
Assignee | ||
Updated•16 years ago
|
Status: REOPENED → RESOLVED
Closed: 16 years ago → 16 years ago
Resolution: --- → FIXED
Updated•11 years ago
|
Product: mozilla.org → Release Engineering
You need to log in
before you can comment on or make changes to this bug.
Description
•