412809 - [Trunk] Customize toolbar dialog w/ Tb trunk breaks a lot of stuff

Status: RESOLVED WORKSFORME

(Calendar :: Lightning Only, defect)

Description

[David Ascher (:davida)]

Steps to reproduce:

Using Thunderbird trunk (version 3.0a1pre (2008011709)), and Lightning trunk (build 2008011709), on OS X.

Right click on toolbar, select Customize.

Expected: usual customization dialog
Actual: dialog w/ no contents.  Error message in console is: 

  Error: window.parent.getMailToolbox is not a function
  Source File: chrome://messenger/content/customizeToolbarSheet.js
  Line: 5

and after that the Calendar and Tasks buttons in the main window are disabled, and lots of stuff doesn't work.

I haven't tried w/ a brand new profile, so it'd be good if someone could try to confirm it.

Comment 1

[Stefan Sitter [:ssitter]]

Currently Trunk builds are not getting much QA and developers attention due to the focus on the Branch builds. There exist more errors that make the Trunk builds almost unusable.

Comment 2

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

on fresh profile in TB trunk version 3.0a1pre (2008011805) and Lightning trunk 2008011805 pre-compiled together, here's the debug output:


when calendar view is selected (after exiting create new account / newsgroup wizard):
==============================
--DOMWINDOW == 15
--DOMWINDOW == 14
WARNING: empty langgroup: file /Users/skywalker/Desktop/Mozilla/cvs/mozilla/gfx/thebes/src/gfxFont.cpp, line 900
WARNING: GetGeckoKeyCodeFromChar has failed.: file /Users/skywalker/Desktop/Mozilla/cvs/mozilla/widget/src/cocoa/nsChildView.mm, line 3316
==============================


upon right clicking and selecting customize:
==============================
WARNING: empty langgroup: file /Users/skywalker/Desktop/Mozilla/cvs/mozilla/gfx/thebes/src/gfxFont.cpp, line 900
++WEBSHELL 0x1a21bb40 == 5
++DOMWINDOW == 15
++DOMWINDOW == 16
WARNING: empty langgroup: file /Users/skywalker/Desktop/Mozilla/cvs/mozilla/gfx/thebes/src/gfxFont.cpp, line 900
JavaScript strict warning: chrome://lightning/content/customize-toolbar.js, line 121: assignment to undeclared variable _repositionDialog
JavaScript strict warning: chrome://lightning/content/customize-toolbar.js, line 191: assignment to undeclared variable _updateToolbarLocation
JavaScript strict warning: chrome://lightning/content/customize-toolbar.js, line 229: assignment to undeclared variable _updateToolbarSelection
JavaScript strict warning: chrome://lightning/content/customize-toolbar.js, line 269: assignment to undeclared variable _updateLocationVisibility
JavaScript strict warning: chrome://lightning/content/customize-toolbar.js, line 284: assignment to undeclared variable _buildPalette
JavaScript strict warning: chrome://lightning/content/customize-toolbar.js, line 358: assignment to undeclared variable updateToolbarLocation
JavaScript strict warning: chrome://lightning/content/customize-toolbar.js, line 359: assignment to undeclared variable updateToolbarSelection
JavaScript strict warning: chrome://lightning/content/customize-toolbar.js, line 360: assignment to undeclared variable updateLocationVisibility
WARNING: empty langgroup: file /Users/skywalker/Desktop/Mozilla/cvs/mozilla/gfx/thebes/src/gfxFont.cpp, line 900
JavaScript error: chrome://messenger/content/customizeToolbarSheet.js, line 5: window.parent.getMailToolbox is not a function
==============================


after that I keep seeing this error, together with disabled Calendar and Tasks buttons:
==============================
WARNING: GetGeckoKeyCodeFromChar has failed.: file /Users/skywalker/Desktop/Mozilla/cvs/mozilla/widget/src/cocoa/nsChildView.mm, line 3316
==============================


upon quitting, no matter whether with mouse or keyboard:
==============================
WARNING: NS_ENSURE_TRUE(domDoc) failed: file /Users/skywalker/Desktop/Mozilla/cvs/mozilla/content/xul/content/src/nsXULElement.cpp, line 1505
==============================

and the app seemingly does nothing. It's not a hang, since Spin Control.app senses nothing.

... suspects Gecko 1.9 (cocoa widget) problem.

Comment 3

[Stefan Sitter [:ssitter]]

Works for me using Thunderbird Trunk 3.0a1pre (2008021403) and Lightning Trunk 0.6a1 (2008021320) on Windows XP.

David, does this error still exist on Mac OS X with recent builds?

Could you retest if the same error occurs in a Thunderbird build without Lightning being installed?

Comment 4

[Mark Banner (:standard8)]

(In reply to comment #3)
> Could you retest if the same error occurs in a Thunderbird build without
> Lightning being installed?

I can reproduce David's comment 0 with latest trunk (2008041403) and lightning (2008041418). It does not happen when lightning is disabled.

Comment 5

[Philipp Kewisch [:Fallen][☁️📆]]

Given that we are planning to get rid of the toolbar, does this bug still need fixing? In any case, the customize stuff wasn't totally broken for me, just a couple of warnings and minor issues. I have a patch that partially fixes the issues I've been seeing, all that is left is bug 455248 and the switching not quite working out.

Comment 6

[Philipp Kewisch [:Fallen][☁️📆]]

Rerequesting flags, see comment 5.

Comment 7

[David Ascher (:davida)]

My understanding is that we'll keep the toolbar, just change what is shown by default.  So it feels like this is still a big deal.

Comment 8

[Daniel Boelzle [:dbo]]

Customize toolbar works for me (on Mac); could we close this one?

Comment 9

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

(In reply to comment #8)
> Customize toolbar works for me (on Mac); could we close this one?

WFM too. I could bring up the Customize Toolbar dialog when on Lightning / Tasks tab.