412824 - UI misalignment after checking for addon updates

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

ui-poish. Minor, but visible -- see attached screenshot.  The "No updates found" etc. lines are misaligned from the rest of the messages that show up in that label in the addons manager.  (Visible after clicking check for updates.)

Comment 1

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Please attach the screenshot.

Comment 2

[Dave Townsend [:mossop]]

It's fine I know the problem, thanks for filing this Vlad, kept meaning to tweak this right but always slipped my mind!

Comment 3

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Whoops, I blame bugzilla.  Not sure what happened, but sounds like Dave knows what's going on (I deleted the screenshot already).  Some quick ascii art just in case:

Normally:

     Adblock Plus  0.7.5.3
     Ads were yesterday!

After Find Updates:

     Adblock Plus  0.7.5.3
   No updates were found.

   ^ that alignment; ends up running right up against the icon.

Comment 4

[Dave Townsend [:mossop]]

Attachment: patch rev 1

Can't see any reason why these items were descriptions as opposed to labels used everywhere else in the UI, but descriptions have less padding than labels do by default which causes the issue.

Comment 5

[Dave Townsend [:mossop]]

Comment on attachment 301883 [details] [diff] [review]
patch rev 1

Approval for a minor UI fix.

Comment 6

[Mike Beltzner [:beltzner, not reading bugmail]]

Fixed?

Comment 7

[Dave Townsend [:mossop]]

(In reply to comment #6)
> Fixed?

Will be as soon as the tree opens

Comment 8

[Dave Townsend [:mossop]]

Checking in toolkit/mozapps/extensions/content/extensions.xml;
/cvsroot/mozilla/toolkit/mozapps/extensions/content/extensions.xml,v  <--  extensions.xml
new revision: 1.54; previous revision: 1.53
done