re-enable search service logging for non-debug builds

RESOLVED FIXED in Firefox 3 beta3

Status

()

P3
normal
RESOLVED FIXED
11 years ago
11 years ago

People

(Reporter: Gavin, Assigned: Gavin)

Tracking

Trunk
Firefox 3 beta3
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Bug 394979 disabled search service logging for non-debug builds, because it was showing up in some Tp runs. Since this code has been useful for remotely debugging search service problems, I think we should re-enable it, but not have it be "live" to avoid the perf costs of the previous approach (which checked the pref each time the LOG function was called). We can do this by dynamically defining the LOG function based on the pref value at startup.
Created attachment 297776 [details] [diff] [review]
patch
Assignee: nobody → gavin.sharp
Status: NEW → ASSIGNED
Attachment #297776 - Flags: review?(mano)
Priority: -- → P3
Target Milestone: --- → Firefox 3 M11
So, why is PREF_LOG still checking the pref too?
PREF_LOG is the version used for debug builds, and it checks the pref because I've found useful to be able to dynamically enable/disable logging while I'm testing something (to reduce log noise). I'm not particularly attached to it, though, so perhaps we should just omit it for simplicity's sake.
Comment on attachment 297776 [details] [diff] [review]
patch

seems fine actually, r=mano.
Attachment #297776 - Flags: review?(mano) → review+
Comment on attachment 297776 [details] [diff] [review]
patch

Restores a feature that has helped remotely debug search services issues in the past, should have no impact unless enabled with the pref.
Attachment #297776 - Flags: approval1.9?
Comment on attachment 297776 [details] [diff] [review]
patch

a=beltzner for 1.9
Attachment #297776 - Flags: approval1.9? → approval1.9+
Keywords: checkin-needed
mozilla/browser/components/search/nsSearchService.js 	1.108 
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.