412960 - re-enable search service logging for non-debug builds

Status: RESOLVED FIXED

(Firefox :: Search, defect, P3)

Description

[:Gavin Sharp [email: [e-mail]]]

Bug 394979 disabled search service logging for non-debug builds, because it was showing up in some Tp runs. Since this code has been useful for remotely debugging search service problems, I think we should re-enable it, but not have it be "live" to avoid the perf costs of the previous approach (which checked the pref each time the LOG function was called). We can do this by dynamically defining the LOG function based on the pref value at startup.

Comment 1

[:Gavin Sharp [email: [e-mail]]]

Attachment: patch

Comment 2

[Asaf Romano (gone)]

So, why is PREF_LOG still checking the pref too?

Comment 3

[:Gavin Sharp [email: [e-mail]]]

PREF_LOG is the version used for debug builds, and it checks the pref because I've found useful to be able to dynamically enable/disable logging while I'm testing something (to reduce log noise). I'm not particularly attached to it, though, so perhaps we should just omit it for simplicity's sake.

Comment 4

[Asaf Romano (gone)]

Comment on attachment 297776 [details] [diff] [review]
patch

seems fine actually, r=mano.

Comment 5

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 297776 [details] [diff] [review]
patch

Restores a feature that has helped remotely debug search services issues in the past, should have no impact unless enabled with the pref.

Comment 6

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 297776 [details] [diff] [review]
patch

a=beltzner for 1.9

Comment 7

[:Gavin Sharp [email: [e-mail]]]

mozilla/browser/components/search/nsSearchService.js 	1.108