Focused button is not highlighted, but the hover one does

NEW
Unassigned

Status

()

Core
Widget: Gtk
10 years ago
10 years ago

People

(Reporter: zwnj, Unassigned)

Tracking

(Depends on: 1 bug)

Trunk
x86
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(4 attachments)

(Reporter)

Description

10 years ago
When a Form object is focues, the button which will be fired with pressing Enter is not highlighted in Fx, like desktop applications, ie. in Ubuntu's Human theme, that button has an orange inner-shadow.

Unfortunately there's no highlight for focused button at all, which makes solving that more necessary.

AFAIK it's not a simple CSS fix, as there's no selector for this objects; but this is a really big problem in keyboard navigation.
> Unfortunately there's no highlight for focused button at all

This worksforme over here, both with and without native theming.  Am I missing something?

> AFAIK it's not a simple CSS fix, as there's no selector for this objects

So what you want is that when a button has focus it's the thing highlighted, but when a textfield or some such has focus the default button is highlighted?

If so, that's bug 102057 as far as I can tell.
(Reporter)

Comment 2

10 years ago
(In reply to comment #1)
> > Unfortunately there's no highlight for focused button at all
> 
> This worksforme over here, both with and without native theming.  Am I missing
> something?

I just get a dotted border for the text inside the button.

> So what you want is that when a button has focus it's the thing highlighted,
> but when a textfield or some such has focus the default button is highlighted?
> 
> If so, that's bug 102057 as far as I can tell.

Yes, this part is a DUP.

So the only problem here, in lack of a fix for bug 102057, is that when I have a keyboard focus on button 1, and a mouse hover on button 2, just one of them is highlighted, and it's a bit confusing for simple user.

I'm gonna attach the screenshot.
Summary: The button for Enter action is not highlighted (like in desktop apps) → Focused button is not highlighted, but the hover one does
(Reporter)

Comment 3

10 years ago
Created attachment 297802 [details]
focused and hovered buttons.png

It's in Ubuntu's Human theme again.

The left one has focus, and the right one has hover.
> I just get a dotted border for the text inside the button.

Yes, that's the focus indicator.  If you mean we should have a themed focus indicator, that wouldn't be a form controls bug but a gtk theming bug.

I'm a little confused by the focus/hover thing, but that might be because I'm not seeing that effect here.  In any case, that's also not a form controls bug.
Component: Layout: Form Controls → Widget: Gtk
QA Contact: layout.form-controls → gtk
(Reporter)

Comment 5

10 years ago
Created attachment 297835 [details]
GNOME Run Application - "Run with file..." focused

"Run with file..." button is focused here.  There's no glow for focusing of this kind of button.
(Reporter)

Comment 6

10 years ago
Created attachment 297838 [details]
GNOME Run Application - "Run" focused

"Run" button is focused here.  So you see the inner highlight glow.

I'm not sure about the differences of these buttons in GTK, but seems "Run with file..." is a [Browse] like button, which just helps user to select a file, not type the path.  But the "Run" button is a [Submit]/[Reset] like button, which does something with the whole application/form/page.  So, I wanna suggest to do the same here.

Comment 7

10 years ago
While Run is focused, that is not why it is highlighted.  That is because it is the default button.  Being focused and being a default button are two different things
(Reporter)

Comment 8

10 years ago
(In reply to comment #7)
> While Run is focused, that is not why it is highlighted.  That is because it is
> the default button.  Being focused and being a default button are two different
> things

You cannot say so.  When "Run with file.." is focused it's default too; Enter opens a file chooser.  But there's a tight relation between these.

I remember some themes have inner gray glow for default, which became inner highlight glow if focused.  But seems highlighting non-focused default button is more user-friendly.

BTW, as we don't have any support for "default" selector, I wanna at least have inner highlight glow for focused (every focused button is default) button.

Also it's not just about buttons; focused drop-down select options should have inner highlight glow too.
(Reporter)

Comment 9

10 years ago
Created attachment 297943 [details]
focused-vs-default-in-xul.png

Oh, here are one of the worst cases.  In the add-bookmark panel, focusing to "Delete" doesn't make is the default, causing pressing Enter on "Delete" button doesn't work.  Also seems we have some kind of highlighting for default buttons in XUL.  We need to make sure we don't highlight two buttons in these cases.
(Reporter)

Updated

10 years ago
Depends on: 413114
You need to log in before you can comment on or make changes to this bug.