413034 - Remove use of PRInt32 in Keychain code

Status: RESOLVED FIXED

(Camino Graveyard :: OS Integration, defect)

Description

[Bryan Atwood]

Functions in KeychainService.* (and upcoming KeychainAutoCompleteSession.*)
 use PRInt32 type but this should be changed to use something more Cocoa-y

Comment 1

[Bryan Atwood]

Attachment: Patch to change PRInt32 to UInt32

I had prepared this on Mento's suggestion to change PRInt32 method arguments to UInt32.  Instead of carrying around -1 for the port value, it's quickly set to kAnyPort since UInt32 is unsigned.

Comment 2

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Checked in on the trunk and MOZILLA_1_8_BRANCH.

Comment 3

[Mark Mentovai]

Attachment: Missed a kAnyPort

Brian, I didn't see this one because it was cut out by patch context - actually, in the patch context, it looked kind of right.  ExtractRealmComponents had its port (out-)parameter changed from a PRInt32 to a UInt16, but it's still setting it to -1.  Is kAnyPort correct to use here?

ExtractRealmComponents was a protected static member function in KeychainPrompt, but it didn't even need that kind of visibility.  In this patch, I've made it a simple static function, and have given its buddies PreFill and ProcessPrompt the same treatment.  (The latter two weren't even static, although they didn't operate on an object.)

Comment 4

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Comment on attachment 299837 [details] [diff] [review]
Missed a kAnyPort

Obsoleting this patch; Stuart landed the kAnyPort at some point, and the static stuff now has its own bug, bug 425258.