413184 - Unify all of the update_ functions in Bugzilla::Bug

Status: RESOLVED FIXED

(Bugzilla :: Creating/Changing Bugs, enhancement)

Description

[Max Kanat-Alexander]

While we were re-writing process_bug, we had to create several different update_ functions that added things to the database at different times. Now that we're all done, we can unify them all into update().

Comment 1

[Max Kanat-Alexander]

Attachment: v1

Okay, this is a pretty nice cleanup.

I've tested this.

Comment 2

[Frédéric Buclin]

Comment on attachment 311481 [details] [diff] [review]
v1

>Index: process_bug.cgi

>-    my @all_changed_deps = map { @$_ } @{$dep_changes->{'dependson'}};
>-    push(@all_changed_deps, map { @$_ } @{$dep_changes->{'blocked'}});
>-    my %changed_deps = map { $_ => 1 } @all_changed_deps;

>+    my $all_changed_deps = join(', ', @{ $changes->{'dependson'} || [] });
>+    $all_changed_deps = join(', ', @{ $changes->{'blocked'} || [] },
>+                                   $all_changed_deps);
>+    my %changed_deps = map { $_ => 1 } split(', ', $all_changed_deps);
>+    delete $changed_deps{''};

Nit: not sure this is clearer than what was done before. Also, you could write ',' instead of ', ' as you split on it right after and this string is never passed to the UI.


>+        cc        => [split(/,\s/, $old_cc)],

Nit: split(/[\s,]+/, $old_cc) would be safer IMO (unless commas are allowed in email addresses?).


Otherwise looks good and works fine. r=LpSolit

Comment 3

[Max Kanat-Alexander]

(In reply to comment #2)
> Nit: not sure this is clearer than what was done before. Also, you could write
> ',' instead of ', ' as you split on it right after and this string is never
> passed to the UI.

  It's not an issue of being clearer than before. Before we were getting arrays of arrays, now we're getting arrays of strings, so we have to actually have different code.

> Nit: split(/[\s,]+/, $old_cc) would be safer IMO (unless commas are allowed in
> email addresses?).

  Will do.

Comment 4

[Max Kanat-Alexander]

Did the fix on checkin.

Checking in process_bug.cgi;
/cvsroot/mozilla/webtools/bugzilla/process_bug.cgi,v  <--  process_bug.cgi
new revision: 1.408; previous revision: 1.407
done
Checking in Bugzilla/Bug.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Bug.pm,v  <--  Bug.pm
new revision: 1.237; previous revision: 1.236
done