413195 - Warning: XUL box for a element contained an inline #text child, forcing all its children to be wrapped in a block.

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Matthew Cline]

Attachment: Stack trace of when the warning is issued

I get the JS warning "Warning: XUL box for a element contained an inline #text child, forcing all its children to be wrapped in a block." on many pages at deviantART.  For each page with the problem, it appears four times.  I don't notice any problems with the pages that generate this warning.

I can't figure out the best component to place this as I can't figure out how to extract the name of the XUL file being rendered, so layout/base/nsCSSFrameConstructor.cpp suggests putting it here.

Comment 1

[Matthew Cline]

In a reduced test-case it comes down to this bit of CSS:

div.supernav a:-moz-any-link { display:-moz-inline-box; }

Comment 2

[Matthew Cline]

Attachment: Reduced test case

Comment 3

[Matthew Cline]

Attachment: Reduced test case

Oops, uploaded the wrong file.

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

It would be a lot better if pages didn't use this, though.  Authors used to use display:-moz-inline-box to work around lack of correct support for inline-block.  However, we now support inline-block; as long as their display:inline-block is after their display:-moz-inline-box the warning won't happen, and that's the way they should be writing it.

In cases where the warning shows in chrome (and in some cases where it shows in content), there are real problems.

I'm not sure what there is to fix here (unless you want to move this to tech. evang.)

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

s/correct support/support/  (In previous releases, we supported -moz-inline-block, and it often didn't work right.  In Fx3, we support inline-block, and it works correctly.)

Comment 6

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Though I suppose we could extend the warning message with something like:

  (Did you use display:-moz-inline-box without using display:inline-block
  afterwards?)

perhaps only for cases where it shows up in content (rather than chrome).

Comment 7

[Matthew Cline]

So if I were to open a bug report at deviantART, should I tell them to simply change -moz-inline-box to inline-box?

Comment 8

[Matthew Cline]

Oh, duh, FF3 is still in beta, so of course they still have to use -moz-inline-block.

Comment 9

[Boris Zbarsky [:bzbarsky]]

They should be using either:

  display: inline-block;

or:

  display: -moz-inline-box;
  display: inline-block;

Comment 10

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: improve error message in -moz-inline-box case

I think enough pages do this that it's worth having a more explanatory error message here.  I'd like to try getting this in before the l10n freeze tomorrow.

Duplicating the text across the two strings in xul.properties seems the simplest solution here.

Comment 11

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 299060 [details] [diff] [review]
improve error message in -moz-inline-box case

Looks good.

Comment 12

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 299060 [details] [diff] [review]
improve error message in -moz-inline-box case

a=beltzner for 1.9

Comment 13

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

More informative warning checked in to trunk two minutes ago.

Not much else we can do here; marking fixed.