413198 - Make layout.css.report_errors apply to debug build text terminal (stderr)

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement)

Description

[Matthew Cline]

Attachment: check gReportErrors before sending CSS errors to stderr

This is a trivial patch to make the layout.css.report_errors preference apply to the copy of CSS errors that go to stderr in debug builds.  Useful if you're looking for assertions on a site which spews out tons of CSS errors.

Comment 1

[:Gavin Sharp [email: [e-mail]]]

Matthew: please ask dbaron to review (using review flags) and get approval1.9+ before marking checkin-needed.

Comment 2

[:Gavin Sharp [email: [e-mail]]]

You're going to want to set that flag to "?" rather than "+", and enter dbaron's email address (dbaron@moz) in the "requestee" field :)

Comment 3

[Matthew Cline]

Comment on attachment 298067 [details] [diff] [review]
check gReportErrors before sending CSS errors to stderr

Ah, sorry, I'm new to all this.

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 298067 [details] [diff] [review]
check gReportErrors before sending CSS errors to stderr

r+sr=dbaron

(I suppose if some chrome developers turn this off, other people will still notice the errors.)

Comment 5

[Reed Loden [:reed]]

Checking in layout/style/nsCSSScanner.cpp;
/cvsroot/mozilla/layout/style/nsCSSScanner.cpp,v  <--  nsCSSScanner.cpp
new revision: 3.97; previous revision: 3.96
done