Allow building GtkMozEmbed without MOZILLA_INTERNAL_API

RESOLVED FIXED in mozilla1.9.1a1

Status

Core Graveyard
Embedding: GTK Widget
RESOLVED FIXED
10 years ago
6 years ago

People

(Reporter: romaxa, Assigned: romaxa)

Tracking

Trunk
mozilla1.9.1a1
x86
Linux

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

10 years ago
Created attachment 298108 [details] [diff] [review]
Bugfix.

Patch for building gtkmozembed widget without MOZILLA_INTERNAL_API in attachments.
Attachment #298108 - Flags: review?(benjamin)
(Assignee)

Updated

10 years ago
Status: NEW → ASSIGNED
(Assignee)

Updated

10 years ago
Assignee: nobody → romaxa
Status: ASSIGNED → NEW

Comment 1

10 years ago
Comment on attachment 298108 [details] [diff] [review]
Bugfix.

I don't think we want this patch... if we do, please comment why and re-request review.
Attachment #298108 - Flags: review?(benjamin)
(Assignee)

Comment 2

10 years ago
If somebody wants to build their own (extended) version of libgtkmozmebed, they will take current version and try to build it outside... and it will not work because it require this patch.
(Assignee)

Updated

10 years ago
Attachment #298108 - Flags: review?(benjamin)

Updated

10 years ago
Attachment #298108 - Flags: review?(benjamin) → review+
(Assignee)

Updated

10 years ago
Keywords: checkin-needed
romaxa, this patch is super-bitrotten. Can you submit a new patch and add checkin-needed again?
Keywords: checkin-needed
(Assignee)

Comment 4

10 years ago
Created attachment 329612 [details] [diff] [review]
Bugfix updated to trunk
Attachment #298108 - Attachment is obsolete: true
(Assignee)

Updated

10 years ago
Keywords: checkin-needed
Pushed to mozilla-central:
http://hg.mozilla.org/mozilla-central/index.cgi/rev/884012d735c9
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.1a1
Component: Embedding: GTK Widget → Embedding: GTK Widget
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.