Closed
Bug 413219
Opened 16 years ago
Closed 16 years ago
Allow building GtkMozEmbed without MOZILLA_INTERNAL_API
Categories
(Core Graveyard :: Embedding: GTK Widget, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla1.9.1a1
People
(Reporter: romaxa, Assigned: romaxa)
Details
Attachments
(1 file, 1 obsolete file)
11.36 KB,
patch
|
Details | Diff | Splinter Review |
Patch for building gtkmozembed widget without MOZILLA_INTERNAL_API in attachments.
Attachment #298108 -
Flags: review?(benjamin)
Assignee | ||
Updated•16 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Updated•16 years ago
|
Assignee: nobody → romaxa
Status: ASSIGNED → NEW
Comment 1•16 years ago
|
||
Comment on attachment 298108 [details] [diff] [review] Bugfix. I don't think we want this patch... if we do, please comment why and re-request review.
Attachment #298108 -
Flags: review?(benjamin)
Assignee | ||
Comment 2•16 years ago
|
||
If somebody wants to build their own (extended) version of libgtkmozmebed, they will take current version and try to build it outside... and it will not work because it require this patch.
Assignee | ||
Updated•16 years ago
|
Attachment #298108 -
Flags: review?(benjamin)
Updated•16 years ago
|
Attachment #298108 -
Flags: review?(benjamin) → review+
Assignee | ||
Updated•16 years ago
|
Keywords: checkin-needed
Comment 3•16 years ago
|
||
romaxa, this patch is super-bitrotten. Can you submit a new patch and add checkin-needed again?
Keywords: checkin-needed
Assignee | ||
Comment 4•16 years ago
|
||
Attachment #298108 -
Attachment is obsolete: true
Assignee | ||
Updated•16 years ago
|
Keywords: checkin-needed
Comment 5•16 years ago
|
||
Pushed to mozilla-central: http://hg.mozilla.org/mozilla-central/index.cgi/rev/884012d735c9
Status: NEW → RESOLVED
Closed: 16 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.1a1
Updated•12 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•