Closed Bug 413219 Opened 16 years ago Closed 16 years ago

Allow building GtkMozEmbed without MOZILLA_INTERNAL_API

Categories

(Core Graveyard :: Embedding: GTK Widget, defect)

x86
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla1.9.1a1

People

(Reporter: romaxa, Assigned: romaxa)

Details

Attachments

(1 file, 1 obsolete file)

Attached patch Bugfix. (obsolete) — Splinter Review
Patch for building gtkmozembed widget without MOZILLA_INTERNAL_API in attachments.
Attachment #298108 - Flags: review?(benjamin)
Status: NEW → ASSIGNED
Assignee: nobody → romaxa
Status: ASSIGNED → NEW
Comment on attachment 298108 [details] [diff] [review]
Bugfix.

I don't think we want this patch... if we do, please comment why and re-request review.
Attachment #298108 - Flags: review?(benjamin)
If somebody wants to build their own (extended) version of libgtkmozmebed, they will take current version and try to build it outside... and it will not work because it require this patch.
Attachment #298108 - Flags: review?(benjamin)
Attachment #298108 - Flags: review?(benjamin) → review+
Keywords: checkin-needed
romaxa, this patch is super-bitrotten. Can you submit a new patch and add checkin-needed again?
Keywords: checkin-needed
Attachment #298108 - Attachment is obsolete: true
Keywords: checkin-needed
Pushed to mozilla-central:
http://hg.mozilla.org/mozilla-central/index.cgi/rev/884012d735c9
Status: NEW → RESOLVED
Closed: 16 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.1a1
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: