413255 - [valgrind] pref_savePref: Conditional jump or move depends on uninitialised value

Status: RESOLVED FIXED

(Core :: Preferences: Backend, defect)

Description

[Robert Sayre]

==7262== Conditional jump or move depends on uninitialised value(s)
==7262==    at 0x6CEE148: pref_savePref(PLDHashTable*, PLDHashEntryHdr*, unsigned, void*) (prefapi.cpp:364)
==7262==    by 0x4143218: PL_DHashTableEnumerate (pldhash.c:724)
==7262==    by 0x6CEA6F3: nsPrefService::WritePrefFile(nsIFile*) (nsPrefService.cpp:536)
==7262==    by 0x6CEA91C: nsPrefService::SavePrefFileInternal(nsIFile*) (nsPrefService.cpp:461)
==7262==    by 0x6CEA968: nsPrefService::SavePrefFile(nsIFile*) (nsPrefService.cpp:250)
==7262==    by 0x5D7A1A0: nsNavHistory::Observe(nsISupports*, char const*, unsigned short const*) (nsNavHistory.cpp:3586)
==7262==    by 0x415952F: nsObserverList::NotifyObservers(nsISupports*, char const*, unsigned short const*) (nsObserverList.cpp:128)
==7262==    by 0x415A1CB: nsObserverService::NotifyObservers(nsISupports*, char const*, unsigned short const*) (nsObserverService.cpp:181)
==7262==    by 0x5CEC4E7: nsAppStartup::Quit(unsigned) (nsAppStartup.cpp:311)
==7262==    by 0x5CEBCB1: nsAppStartup::ExitLastWindowClosingSurvivalArea() (nsAppStartup.cpp:406)
==7262==    by 0x5CEC36D: nsAppStartup::Observe(nsISupports*, char const*, unsigned short const*) (nsAppStartup.cpp:499)
==7262==    by 0x415952F: nsObserverList::NotifyObservers(nsISupports*, char const*, unsigned short const*) (nsObserverList.cpp:128)

Comment 1

[Mats Palmgren (inactive)]

STR?

Comment 2

[Robert Sayre]

Sorry. 

1.) apply patch from bug 413170
2.) clear profile
3.) print attachment 296882 [details] [details] from bug 411369.

Comment 3

[Robert Sayre]

4.) Quit

Comment 4

[Mats Palmgren (inactive)]

Attachment: Patch rev. 1

'mDownloadFonts' is never initialized, which causes the default value
for the "print.printer_*.print_downloadfonts" pref to be uninitialized.

Comment 5

[Mats Palmgren (inactive)]

mozilla/widget/src/xpwidgets/nsPrintSettingsImpl.cpp 	1.43 

-> FIXED