Closed Bug 413312 Opened 17 years ago Closed 17 years ago

Autocomplete dropmarker styling is different if site is secure

Categories

(Firefox :: Address Bar, defect)

x86
Windows XP
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 3 beta3

People

(Reporter: stevee, Assigned: dao)

References

Details

(Keywords: regression)

Attachments

(2 files)

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b3pre) Gecko/2008012004 Minefield/3.0b3pre ID:2008012004

Bug 397331 changed the auto-complete drop-down styling to look like attachment 297257 [details]. For me I see this styling on normal sites, but on secure sites when the location bar background colour changes to yellow, hovering the dropdown marker just draws a box around it rather than styles it to look like a normal widget.

I think I would expect it to look as per attachment 297257 [details].

(I don't know if this matters, but I use classic theme in WinXP)
Attached patch patchSplinter Review
Assignee: nobody → dao
Status: NEW → ASSIGNED
Attachment #298309 - Flags: review?(mano)
(In reply to comment #0)
> (I don't know if this matters, but I use classic theme in WinXP)

It does matter, because classic themes don't provide a 'toolbox' appearance.
Keywords: regression
Flags: blocking-firefox3?
Comment on attachment 298309 [details] [diff] [review]
patch

That background color discrepancy between the hovered and non-hovered state is intentional? Looks really weird :/
Attachment #298309 - Flags: review?(mano) → review+
(In reply to comment #3)
> (From update of attachment 298309 [details] [diff] [review])
> That background color discrepancy between the hovered and non-hovered state is
> intentional?

It is. I think we can do better in the Windows classic case, but that's something for a different bug.
Attachment #298309 - Flags: approval1.9?
Attachment #298309 - Flags: approval1.9? → approval1.9+
Keywords: checkin-needed
Checking in browser/themes/winstripe/browser/browser.css;
/cvsroot/mozilla/browser/themes/winstripe/browser/browser.css,v  <--  browser.css
new revision: 1.152; previous revision: 1.151
done
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3 M11
Flags: blocking-firefox3?
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: