41337 - /join should join the current window if it is a channel and you are not currently in it

Status: RESOLVED WONTFIX

(Other Applications Graveyard :: ChatZilla, enhancement, P3)

Description

[timeless]

since we have a separate pane for each channel, if you part or are kicked from 
a channel and still have the pane open, typing /join with that pane open should 
join that channel

Comment 1

[Robert Ginda]

mass accepting chatzilla bugs and marking "future"

Comment 2

[David Krause]

*MASS SPAM*

Changing QA contact on all open or unverified ChatZilla bugs to me, David
Krause, as I am now the QA contact for this component.

Comment 3

[Robert Ginda]

I've got a patch for this in my local tree, soon to be posted as part of bug 89713

Comment 4

[Robert Ginda]

fix checked in

Comment 5

[Stephanie Daugherty [:sdaugherty]]

Reopening. /join in this case now performs a /list and opens a channel list dialog box. Looks like we regressed at some point with this, and I would argue that it's a dangerous regression, as on large networks, /list is likely to disconnect the client rather abruptly, or at least make the connection to the server unusable for several seconds while all the data is transmitted.

Comment 6

[:Gijs (he/him)]

Attachment: Patch

Oops. Best fix that. :-)

Comment 7

[James Ross]

Comment on attachment 249501 [details] [diff] [review]
Patch

>+    // If we left a channel, rejoin it:
>+    if (e.channel && !e.channel.active)
>+    {
>+        e.channel.join(e.channel.mode.key);

I think you want e.channel.joined, not e.channel.active. Not entirely keen on this change in the first place, let along the command changing behaviour entirely based on whether you're joined or not.

r=silver, but someone will complain.

Comment 8

[James Ross]

Comment on attachment 249501 [details] [diff] [review]
Patch

This breaks the IRC > Join channel... menu item. No go.

Comment 9

[James Ross]

Going to WONTFIX this one; we have /rejoin to join the current channel if you're no already in it, plus various parts of the UI you can click (there's usually at least two links visible that'll work). Having /join behave differently depending on the tab, and joined-ness, is counter0intuative, too.