413443 - Deal with hyphens in flag names

Status: RESOLVED DUPLICATE of bug 880282

(Bugzilla :: Query/Bug List, defect)

Description

[Matthew Cline]

If you copy a flag name from a bug, like "blocking‑firefox3", the dash will be the special non-breaking hyphen character (‑) rather than an ASCII "-".  Thus if you copy-paste a flag name into the Bugzilla search form you won't get any hits; you have to delete the dash and type it in again as an ASCII "-" to get the expected results.

Comment 1

[Frédéric Buclin]

For the record, the reason is that flags are filtered using FILTER no_break, which do the following changes:

 $var =~ s/ /\ /g;
 $var =~ s/-/\‑/g;

I'm not sure how this bug should be fixed. Either in buglist.cgi before passing data to Search.pm or in Search.pm itself.

Comment 2

[Jesse Clark]

Attachment: search.pm fix

This will de-filter flag names in Search.pm but I run into a tainting error when I try to test it.

Comment 3

[Frédéric Buclin]

This bug is really visible on b.m.o as many flag names have hyphens in them. Definitely something we should fix. Max, could you have a look at this small patch?

Comment 4

[Max Kanat-Alexander]

Comment on attachment 299903 [details] [diff] [review]
search.pm fix

I'm not getting a taint error, but this doesn't seem to fix the bug for me, on testing.

Comment 5

[Frédéric Buclin]

The Bugzilla 3.0 branch is now locked to security bugs and dataloss fixes only. This bug doesn't fit into one of these two categories and is retargetted to 3.2 as part of a mass-change. To catch bugmails related to this mass-change, use lts081207 in your email client filter.

Comment 6

[Frédéric Buclin]

Bugzilla 3.2 is restricted to security bugs only. Moreover, this bug is either assigned to nobody or got no traction for several months now. Rather than retargetting it at each new release, I'm clearing the target milestone and the bug will be retargetted to some sensible release when someone starts fixing this bug for real (Bugzilla 3.8 more likely).

Comment 7

[Frédéric Buclin]

This has been fixed in Bugzilla 5.0.