413444 - [10.5] Autocomplete windows' cells are semi-editable

Status: RESOLVED FIXED

(Camino Graveyard :: Location Bar & Autocomplete, defect)

Description

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

This happens in both the location bar's autocomplete and the forthcoming multiple accounts formfill autocomplete

STR:

1. Type something in the location bar that will trigger autocomplete results
2. Arrow down to highlight a result
3. Click on the highlighted result with the mouse

AR: Entry becomes semi-editable (editable appearance, but no editing can be performed)

ER: Not editable; clicking causes the entry to be chosen for autocomplete and away you go to the new page.

This can be a bit temperamental to reproduce in the location bar autocomplete for some reason, but I can repro 100% of the time with the formfill autocomplete.

I can never repro with 10.3, and given our previous experience with 10.5 NSTableView changes, I expect this is a 10.5 change that we want to override for our "read-only" table views.

Comment 1

[Christopher Henderson]

Attachment: Fix v1.0

Sets the table columns as not editable when awakening from the nib. Probably don't need to do that for the icon column, but I did it anyway. Fixes behaviour on the location bar popup, haven't tested for the formfill.

Comment 2

[Christopher Henderson]

Attachment: Fix v1.1

Added fix for the formfill autocomplete popup.

Comment 3

[Sean Murphy]

Comment on attachment 336596 [details] [diff] [review]
Fix v1.1

r=murph

Comment 4

[Stuart Morgan]

Comment on attachment 336596 [details] [diff] [review]
Fix v1.1

sr=smorgan

Thanks for tackling all these polish issues! We haven't done enough of this lately.

Comment 5

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Landed on cvs trunk.