Closed
Bug 413473
Opened 17 years ago
Closed 16 years ago
Incorrect DONT_TRANSLATE directives
Categories
(Thunderbird :: Address Book, defect)
Thunderbird
Address Book
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 3
People
(Reporter: friedel, Assigned: friedel)
References
Details
Attachments
(1 file)
2.43 KB,
patch
|
philor
:
review+
|
Details | Diff | Splinter Review |
There are incorrect DONT_TRANSLATE comments in mail/locales/en-US/chrome/messenger/addressbook/abMainWindow.dtd that incorrectly instructs translators not to translate accesskeys which should obviously be considered for localisation.
Attachment #298442 -
Flags: review?
Updated•17 years ago
|
Hardware: PC → All
Comment 1•17 years ago
|
||
Isn't it actually correct for the .key ? (That's for the shortcut.) Though I don't see notes about it in many other places... Also, you need to ask review from a specific person.
Updated•17 years ago
|
Assignee: nobody → friedel
Assignee | ||
Comment 2•17 years ago
|
||
.key entries are not marked DONT_TRANSLATE anywhere else. I assume not everybody has Latin keyboards, so they might want to change it. As for review - please enlighten me on the process. How and who?
Comment 3•17 years ago
|
||
command keys have general DONT_TRANSLATE note, I see no problem with leaving the comment for printCardViewCmd.key in. Note that DONT_TRANSLATE doesn't mean that you can't make an educated decision to localize an entry, that's why they're in l10n. It's intended to strongly discourage that though.
Comment 4•17 years ago
|
||
Bleah. One browser/ file has a general Do not translate comment for commandkeys, one suite/ file has one for commandkeys and one other has one for both accesskeys and commandkeys, which I certainly would have interpreted as "in these files only, for some obscure and unstated reason beyond the general 'if possible, it's better to have consistent keyboard shortcuts across locales' reason." Using those, much less mail/'s single commandkey, to mean "even though usually DONT_TRANSLATE means it's a technical term like TOP as an IMAP command, or HTML code, or substitution markers, and translating it *will* break things, in this case it's just a sort of advisory thing, that actually has a much wider scope than the one it's claiming" seems like a rather bad idea. As to review: if you put the email address of someone in http://www.mozilla.org/owners.html#thunderbird (of whom Magnus and I are the best bets at the moment, for these bugs) in the box next to the "?", then that person will get email telling them they need to review the patch, and will have it listed in their "My Requests" list in the footer of every page, and will basically know they need to do it. If you don't request review from someone specifically, well, maybe there will be someone watching all mail to the QA contact who will tell you that you need to specifically request it, or will be able to review and will decide to take the review, or maybe as Dwayne found, your patch will just sit unseen by anyone for years. And yes, those first two paragraphs are a strong hint that if you still want to remove the really-bad-idea note from the single solitary commandkey in mail/ which has one, I would be a good choice as a reviewer ;)
Comment 5•16 years ago
|
||
Comment on attachment 298442 [details] [diff] [review] Remove incorrect DONT_TRANSLATE comments Setting r? on behalf of friedel
Attachment #298442 -
Flags: review? → review?(philringnalda)
Comment 6•16 years ago
|
||
Comment on attachment 298442 [details] [diff] [review] Remove incorrect DONT_TRANSLATE comments Apparently I'm a self-fulfilling prophecy for "will forget to review if it's not in their queue."
Attachment #298442 -
Flags: review?(philringnalda) → review+
Comment 7•16 years ago
|
||
mail/locales/en-US/chrome/messenger/addressbook/abMainWindow.dtd 1.11
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3
You need to log in
before you can comment on or make changes to this bug.
Description
•