Locking browser.startup.homepage should prevent drag/drop to the Home icon
RESOLVED
FIXED
in Firefox 50
Status
()
People
(Reporter: mkaply, Assigned: mkaply)
Tracking
Firefox Tracking Flags
(firefox50 fixed)
Details
Attachments
(1 attachment)
|
664 bytes,
patch
|
enndeakin
:
review+
|
Details | Diff | Splinter Review |
When you lock the homepage preference, the home button should not function as a drop target. Even though the change is not saved, it looks to the user like it is.
|
(Assignee) | |
Comment 1•7 years ago
|
||
Fix would be in browser.js - homeButtonObserver onDragOver
onDragOver: function (aEvent)
{
if (!gPrefService.prefIsLocked("browser.startup.homepage")) {
browserDragAndDrop.dragOver(aEvent);
aEvent.dropEffect = "link";
}
},|
|
(Assignee) | |
Comment 2•3 years ago
|
||
Created attachment 8759867 [details] [diff] [review] Bail out if the homepage pref is locked This seems like the most obvious thing to do. Other option would be to do what my original patch did and only go down this path if the pref is not set. Not sure which is the preferred style.
Assignee: nobody → mozilla
Attachment #8759867 -
Flags: review?(enndeakin)
|
||
Updated•3 years ago
|
Attachment #8759867 -
Flags: review?(enndeakin) → review+
|
|
(Assignee) | |
Comment 3•3 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/883b0a89b3212b6b55b7e6fde69d0438c39899ff Bug 413504 - Don't allow drag and drop to the home button if homepage is locked. r=enndeakin
|
||
Comment 4•3 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/883b0a89b321
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox50: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 50
|
|
||
Comment 5•3 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/883b0a89b321
You need to log in
before you can comment on or make changes to this bug.
Description
•