413504 - Locking browser.startup.homepage should prevent drag/drop to the Home icon

Status: RESOLVED FIXED

(Firefox :: Settings UI, defect)

Description

[Mike Kaply [:mkaply]]

When you lock the homepage preference, the home button should not function as a drop target.

Even though the change is not saved, it looks to the user like it is.

Comment 1

[Mike Kaply [:mkaply]]

Fix would be in browser.js - homeButtonObserver onDragOver


  onDragOver: function (aEvent)
    {
      if (!gPrefService.prefIsLocked("browser.startup.homepage")) {
        browserDragAndDrop.dragOver(aEvent);
        aEvent.dropEffect = "link";
      }
    },

Comment 2

[Mike Kaply [:mkaply]]

Attachment: Bail out if the homepage pref is locked

This seems like the most obvious thing to do.

Other option would be to do what my original patch did and only go down this path if the pref is not set.

Not sure which is the preferred style.

Comment 3

[Mike Kaply [:mkaply]]

https://hg.mozilla.org/integration/fx-team/rev/883b0a89b3212b6b55b7e6fde69d0438c39899ff
Bug 413504 - Don't allow drag and drop to the home button if homepage is locked. r=enndeakin

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/883b0a89b321

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/883b0a89b321