Closed Bug 413504 Opened 14 years ago Closed 6 years ago

Locking browser.startup.homepage should prevent drag/drop to the Home icon

Categories

(Firefox :: Preferences, defect)

Product:
Firefox
Component:
Preferences
Platform:
x86
Windows XP
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 50
Tracking Flags:
Tracking Status
firefox50 --- fixed

People

(Reporter: mkaply, Assigned: mkaply)

Details

Attachments

(1 file)

Bail out if the homepage pref is locked
664 bytes, patch
enndeakin
: review+
Details | Diff | Splinter Review 
When you lock the homepage preference, the home button should not function as a drop target.

Even though the change is not saved, it looks to the user like it is.
Fix would be in browser.js - homeButtonObserver onDragOver


  onDragOver: function (aEvent)
    {
      if (!gPrefService.prefIsLocked("browser.startup.homepage")) {
        browserDragAndDrop.dragOver(aEvent);
        aEvent.dropEffect = "link";
      }
    },
This seems like the most obvious thing to do.

Other option would be to do what my original patch did and only go down this path if the pref is not set.

Not sure which is the preferred style.
Assignee: nobody → mozilla
Attachment #8759867 - Flags: review?(enndeakin)
Attachment #8759867 - Flags: review?(enndeakin) → review+
https://hg.mozilla.org/integration/fx-team/rev/883b0a89b3212b6b55b7e6fde69d0438c39899ff
Bug 413504 - Don't allow drag and drop to the home button if homepage is locked. r=enndeakin
https://hg.mozilla.org/mozilla-central/rev/883b0a89b321
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox50: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 50
You need to log in before you can comment on or make changes to this bug.