Closed Bug 413524 Opened 15 years ago Closed 15 years ago
null-arg checks in ns
Nntp Service .cpp
A bunch of checks for news implementations here. cc-ing Joshua.
Comment on attachment 298520 [details] [diff] [review] patch v1 + NS_ENSURE_ARG_POINTER(aCmdLine); nsresult rv; nit: please add blank line in between these two. r=me.
Comment on attachment 298520 [details] [diff] [review] patch v1 Opps actually, I'm still looking at this one. Sorry, resetting request.
Attachment #298520 - Flags: review+ → review?(bugzilla)
Comment on attachment 298520 [details] [diff] [review] patch v1 nit: please insert blank lines after the added NS_ENSURE_SUCCESS lines and after: + NS_ENSURE_ARG_POINTER(aCmdLine); nsresult rv; r=me with that fixed.
Nits picked, checked in Checking in mailnews/news/src/nsNewsDownloader.cpp; /cvsroot/mozilla/mailnews/news/src/nsNewsDownloader.cpp,v <-- nsNewsDownloader.cpp new revision: 1.36; previous revision: 1.35 done Checking in mailnews/news/src/nsNntpService.cpp; /cvsroot/mozilla/mailnews/news/src/nsNntpService.cpp,v <-- nsNntpService.cpp new revision: 1.277; previous revision: 1.276 done
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.