Closed
Bug 413524
Opened 17 years ago
Closed 17 years ago
null-arg checks in nsNntpService.cpp
Categories
(MailNews Core :: Backend, defect)
MailNews Core
Backend
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jminta, Assigned: jminta)
References
(Blocks 1 open bug)
Details
(Keywords: crash)
Attachments
(1 file)
2.24 KB,
patch
|
standard8
:
review+
|
Details | Diff | Splinter Review |
A bunch of checks for news implementations here. cc-ing Joshua.
Attachment #298520 -
Flags: superreview?(dmose)
Attachment #298520 -
Flags: review?(bugzilla)
Comment 1•17 years ago
|
||
Comment on attachment 298520 [details] [diff] [review]
patch v1
+ NS_ENSURE_ARG_POINTER(aCmdLine);
nsresult rv;
nit: please add blank line in between these two.
r=me.
Attachment #298520 -
Flags: review?(bugzilla) → review+
Comment 2•17 years ago
|
||
Comment on attachment 298520 [details] [diff] [review]
patch v1
Opps actually, I'm still looking at this one. Sorry, resetting request.
Attachment #298520 -
Flags: review+ → review?(bugzilla)
Comment 3•17 years ago
|
||
Comment on attachment 298520 [details] [diff] [review]
patch v1
nit: please insert blank lines after the added NS_ENSURE_SUCCESS lines and after:
+ NS_ENSURE_ARG_POINTER(aCmdLine);
nsresult rv;
r=me with that fixed.
Attachment #298520 -
Flags: review?(bugzilla) → review+
Assignee | ||
Comment 4•17 years ago
|
||
Nits picked, checked in
Checking in mailnews/news/src/nsNewsDownloader.cpp;
/cvsroot/mozilla/mailnews/news/src/nsNewsDownloader.cpp,v <-- nsNewsDownloader.cpp
new revision: 1.36; previous revision: 1.35
done
Checking in mailnews/news/src/nsNntpService.cpp;
/cvsroot/mozilla/mailnews/news/src/nsNntpService.cpp,v <-- nsNntpService.cpp
new revision: 1.277; previous revision: 1.276
done
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•17 years ago
|
Attachment #298520 -
Flags: superreview?(dmose)
Updated•17 years ago
|
Product: Core → MailNews Core
You need to log in
before you can comment on or make changes to this bug.
Description
•