Closed
Bug 413561
Opened 16 years ago
Closed 16 years ago
PRBool misuse (easy fix)
Categories
(Firefox :: Bookmarks & History, defect)
Firefox
Bookmarks & History
Tracking
()
RESOLVED
FIXED
People
(Reporter: taras.mozilla, Assigned: taras.mozilla)
References
Details
Attachments
(1 file)
2.50 KB,
patch
|
dietrich
:
review+
mconnor
:
approval1.9+
|
Details | Diff | Splinter Review |
These look like they should be fixed since they cause seemingly important methods to return true when false should be returned. I'm not sure what (if anything) should be done about passing prbools as int& to methods so I left that unchanged.
Assignee | ||
Updated•16 years ago
|
Attachment #298553 -
Flags: review?(sspitzer)
Comment 1•16 years ago
|
||
I think, judging by the realnames ("not reading, use seth@sspitzer.org") that you requested review from one of Seth's many dead accounts.
OS: Linux → All
Hardware: PC → All
Version: unspecified → Trunk
Assignee | ||
Comment 2•16 years ago
|
||
Comment on attachment 298553 [details] [diff] [review] Correct prbool misuse Thanks for spotting my mistake.
Comment 3•16 years ago
|
||
Comment on attachment 298553 [details] [diff] [review] Correct prbool misuse on a somewhat related note, from https://bugzilla.mozilla.org/attachment.cgi?id=296438 (from bug #394038) + PRBool hidden; // XXX fix me, this should not be a PRBool, as we later do BindInt32Parameter() + PRBool typed; // XXX fix me, this should not be a PRBool, as we later do BindInt32Parameter() Dietrich, can you take this review?
Attachment #298553 -
Flags: review?(sspitzer) → review?(dietrich)
Comment 4•16 years ago
|
||
Comment on attachment 298553 [details] [diff] [review] Correct prbool misuse thanks for catching (and fixing) that, r=me.
Attachment #298553 -
Flags: review?(dietrich) → review+
Comment 5•16 years ago
|
||
Comment on attachment 298553 [details] [diff] [review] Correct prbool misuse drivers: super low impact correctness fix.
Attachment #298553 -
Flags: approval1.9?
Updated•16 years ago
|
Attachment #298553 -
Flags: approval1.9? → approval1.9+
Updated•16 years ago
|
Assignee: nobody → tglek
Assignee | ||
Updated•16 years ago
|
Whiteboard: [checkin-needed]
Updated•16 years ago
|
Whiteboard: [checkin-needed]
Comment 6•16 years ago
|
||
Checking in toolkit/components/places/src/nsNavHistory.cpp; /cvsroot/mozilla/toolkit/components/places/src/nsNavHistory.cpp,v <-- nsNavHistory.cpp new revision: 1.234; previous revision: 1.233 done
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Comment 7•15 years ago
|
||
Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h". In Thunderbird 3.0b, you do that as follows: Tools | Message Filters Make sure the correct account is selected. Click "New" Conditions: Body contains places-to-b-and-h Change the action to "Delete Message". Select "Manually Run" from the dropdown at the top. Click OK. Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter. Gerv
Component: Places → Bookmarks & History
QA Contact: places → bookmarks
You need to log in
before you can comment on or make changes to this bug.
Description
•