413622 - New MIME type set with "Do this automatically ..." doesn't appear in applications list

Status: RESOLVED FIXED

(Core Graveyard :: File Handling, defect, P2)

Description

[Duncan Loveday]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b3pre) Gecko/2008011704 Minefield/3.0b3pre
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b3pre) Gecko/2008010104 Minefield/3.0b3pre 

When FF sees a new MIME type it prompts the user for what they want to do. If
the user clicks "Browse..." and chooses a helper app, then check the "Do this
automatically for files like this from now on" then the file is opened
successfully with the chosen app, however the helper app is not added to the list of applications on the preferences screen.


Reproducible: Always

Steps to Reproduce:
1. Paste this URI into Firefox: "data:application/xyz,a,b,c,d,e"
2. The "Opening application/xyz" dialogue opens.
3. Click "Browse...". The "Choose Helper Application" dialogue appears.
4. Click "Browse..." again. Navigate to an application, e.g. wordpad, excel,
powerpoint etc and select it.
5. The "Choose Helper Application" dialogue disappears and the user is returned
to the "Opening application/xyz" dialogue with the chosen app in the select
list.
6. Check the "Do this automatically for files like this from now on" check box
and click OK.
7. The data "a,b,c,d,e" appears in the chosen app.
8. Select tools->options->applications.
Actual Results:  
In step 8, the new application does not appear.

Expected Results:  
In step 8, the new application should appear.

On windows only, Firefox will also fail to find the application the next time the content type is seen, this is captured in bug 411214.

Comment 1

[Florian Quèze [:florian]]

Ok, I see this on Mac too: when a new MIME type is added and the user selects an action and "Remember", there is no way from the UI to change the action later, despite the "Settings can be changed using the Applications tab" message.

This is related to the pref:
browser.download.hide_plugins_without_extensions

Comment 2

[Florian Quèze [:florian]]

Attachment: patch v1

Trivial patch to make the pref do what its name says.

Comment 3

[Florian Quèze [:florian]]

Nominating for blocking as this was part of a P2 blocker (bug 411214).

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Offhand I don't see why handledOnlyByPlugin should affect a pref named "hideTypesWithoutExtensions", given that we already check for "!primaryExtension", and have another pref that already checks handledOnlyByPlugin. Could you explain?

Comment 5

[Florian Quèze [:florian]]

Err. The name of the pref is "browser.download.hide_plugins_without_extensions".
The variable is probably misnamed and I guess that's what caused the bug.

Comment 6

[Florian Quèze [:florian]]

Attachment: patch v2

Changed the name of the variable.

Comment 7

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 298820 [details] [diff] [review]
patch v2

Ah, I see. This seems pretty obviously correct, given the name of the pref. Perhaps Myk could confirm that this is right, though.

Comment 8

[Myk Melez [:myk] [@mykmelez]]

I don't think this was an accident.  I think there was a reason why I did it this way.  But for the life of me I don't remember what it was now.

Perhaps it was that at one time we weren't going to show types without extensions generally (maybe because the old code did that, and we were maintaining behavior compatibility on the initial rewrite), but we were going to continue to key that behavior off the old pref, so I named the variable to reflect the new behavior even though I couldn't rename the pref.

In any case, we definitely decided that users should be able to see all the types they'd configured in the Choose Application dialog in the Applications prefpane, even if they'd chosen "do this automatically", to give users a way to undo those decisions (per the message to that regard), so this seems like the right change to make.

It's probably worth changing the comment on the code being changed so it refers to plugins specifically rather than "types" generically.

Comment 9

[Florian Quèze [:florian]]

Attachment: patch v3

Updated comment as suggested by Myk.

Comment 10

[Florian Quèze [:florian]]

Checking in browser/components/preferences/applications.js;
/cvsroot/mozilla/browser/components/preferences/applications.js,v  <--  applications.js
new revision: 1.35; previous revision: 1.34
done