413651 - Fix "unused variable" compiler warnings

Status: RESOLVED FIXED

(MailNews Core :: Backend, defect)

Description

[Joey Minta]

Attachment: patch v1

This patch contains a bunch of fixes for compiler warnings about unused variables.  There are still about 8 unused variable warnings that it doesn't address, all of the same format:
nsresult rv = foo();
NS_ASSERTION(NS_SUCCEEDED(rv), "something bad");

I'm not sure about the proper thing to do there.  Nonetheless, here are a bunch of fixes.

Comment 1

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 298704 [details] [diff] [review]
patch v1

r+sr=dmose

Comment 2

[Joey Minta]

Patch checked in.
Checking in mailnews/addrbook/src/nsAbRDFDataSource.cpp;
/cvsroot/mozilla/mailnews/addrbook/src/nsAbRDFDataSource.cpp,v  <--  nsAbRDFDataSource.cpp
new revision: 1.37; previous revision: 1.36
done
Checking in mailnews/base/src/nsMessengerOSXIntegration.cpp;
/cvsroot/mozilla/mailnews/base/src/nsMessengerOSXIntegration.cpp,v  <--  nsMessengerOSXIntegration.cpp
new revision: 1.7; previous revision: 1.6
done
Checking in mailnews/base/src/nsMsgCopyService.cpp;
/cvsroot/mozilla/mailnews/base/src/nsMsgCopyService.cpp,v  <--  nsMsgCopyService.cpp
new revision: 1.60; previous revision: 1.59
done
Checking in mailnews/base/src/nsMsgFolderCompactor.cpp;
/cvsroot/mozilla/mailnews/base/src/nsMsgFolderCompactor.cpp,v  <--  nsMsgFolderCompactor.cpp
new revision: 1.84; previous revision: 1.83
done
Checking in mailnews/base/src/nsMsgGroupView.cpp;
/cvsroot/mozilla/mailnews/base/src/nsMsgGroupView.cpp,v  <--  nsMsgGroupView.cpp
new revision: 1.54; previous revision: 1.53
done
Checking in mailnews/base/util/nsMsgIncomingServer.cpp;
/cvsroot/mozilla/mailnews/base/util/nsMsgIncomingServer.cpp,v  <--  nsMsgIncomingServer.cpp
new revision: 1.266; previous revision: 1.265
done
Checking in mailnews/compose/src/nsMsgSend.cpp;
/cvsroot/mozilla/mailnews/compose/src/nsMsgSend.cpp,v  <--  nsMsgSend.cpp
new revision: 1.420; previous revision: 1.419
done
Checking in mailnews/imap/src/nsImapMailFolder.cpp;
/cvsroot/mozilla/mailnews/imap/src/nsImapMailFolder.cpp,v  <--  nsImapMailFolder.cpp
new revision: 1.801; previous revision: 1.800
done
Checking in mailnews/imap/src/nsImapProtocol.cpp;
/cvsroot/mozilla/mailnews/imap/src/nsImapProtocol.cpp,v  <--  nsImapProtocol.cpp
new revision: 1.679; previous revision: 1.678
done
Checking in mailnews/import/eudora/src/nsEudoraSettings.cpp;
/cvsroot/mozilla/mailnews/import/eudora/src/nsEudoraSettings.cpp,v  <--  nsEudoraSettings.cpp
new revision: 1.14; previous revision: 1.13
done
Checking in mailnews/import/src/ImportOutFile.cpp;
/cvsroot/mozilla/mailnews/import/src/ImportOutFile.cpp,v  <--  ImportOutFile.cpp
new revision: 1.11; previous revision: 1.10
done
Checking in mailnews/mime/cthandlers/vcard/mimevcrd.cpp;
/cvsroot/mozilla/mailnews/mime/cthandlers/vcard/mimevcrd.cpp,v  <--  mimevcrd.cpp
new revision: 1.104; previous revision: 1.103
done
Checking in mailnews/mime/src/nsSimpleMimeConverterStub.cpp;
/cvsroot/mozilla/mailnews/mime/src/nsSimpleMimeConverterStub.cpp,v  <--  nsSimpleMimeConverterStub.cpp
new revision: 1.10; previous revision: 1.9
done
Checking in mailnews/news/src/nsNNTPProtocol.cpp;
/cvsroot/mozilla/mailnews/news/src/nsNNTPProtocol.cpp,v  <--  nsNNTPProtocol.cpp
new revision: 1.397; previous revision: 1.396
done