Closed Bug 413742 Opened 12 years ago Closed 12 years ago

Minotaur L10N run script needs to handle URLs with spaces better

Categories

(Testing Graveyard :: Minotaur, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: cmtalbert, Assigned: cmtalbert)

Details

Attachments

(1 file)

When a URL contains spaces, it is not properly encoded by the run-minotaur.py script before it calls into doDownload (which it should be). Specifically, here is what works and what does not work as parameters for the -u option:
blah%20blah - this will work.
"blah%20blah" - this will work
"blah blah" - this will NOT work (and it should)
blah blah - this will NOT work (and it shouldn't - we have to have quotes).

So, we need to fix the non-encoded, quoted string case above.

We also need to properly report 404's so that if a URL is parsed incorrectly or is mistyped, a logical error message is shown.
Patch outputs some helpful messages for 401 and 404 errors, since those are the most likely to be encountered (due to typos). It will also output a traceback now when it catches an "unknown" error.

It also unquotes the URL in case it is passed in with by hand encoding so that we don't end up with double-encoded URLs.
Assignee: nobody → ctalbert
Status: NEW → ASSIGNED
Attachment #298819 - Flags: review?(rcampbell)
Comment on attachment 298819 [details] [diff] [review]
Patch to handle all encoding issues and to output 401 and 404 errors

Changing reviewer to Alice since Rob C's away.
Attachment #298819 - Flags: review?(rcampbell) → review?(anodelman)
Comment on attachment 298819 [details] [diff] [review]
Patch to handle all encoding issues and to output 401 and 404 errors

Maybe want to print out the errcode in the case where it is neither a 401 or a 404.
Attachment #298819 - Flags: review?(anodelman) → review+
Checked in on Trunk.  --> FIXED
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Mass moving Minotaur bugs to Testing : Minotaur. Filter on MinotaurMassMove to ignore.
Component: Testing → Minotaur
Product: Core → Testing
QA Contact: testing → minotaur
Version: Trunk → unspecified
Product: Testing → Testing Graveyard
You need to log in before you can comment on or make changes to this bug.