Closed Bug 413793 Opened 14 years ago Closed 14 years ago

trunk js shell debug windows fails to link

Categories

(Core :: JavaScript Engine, defect, P2)

x86
Windows XP
defect

Tracking

()

VERIFIED FIXED

People

(Reporter: bc, Assigned: igor)

References

Details

(Keywords: regression)

Attachments

(1 file)

trunk debug js shell fails to build on windows:

js.obj unresolved external symbol _js_Atomize referenced in _DumpStats
Flags: blocking1.9?
Flags: blocking1.9? → blocking1.9+
Priority: -- → P2
Attached patch v1Splinter Review
This is what I am about to check in to fix js shell compilation. 

The changes for bug 413104 have removed the FRIEND specifier from js_Atomize as the browser does not use the function. But I missed the fact that js shell calls it. So the patch replace the call to js_Atomize by JS_ValueToId which is a public API.
Attachment #299844 - Flags: review+
Attachment #299844 - Flags: approval1.9+
I checked in the patch from comment 1 to the trunk:

Checking in js.c;
/cvsroot/mozilla/js/src/js.c,v  <--  js.c
new revision: 3.190; previous revision: 3.189
done
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
thanks.
Status: RESOLVED → VERIFIED
Flags: in-testsuite-
Flags: in-litmus-
You need to log in before you can comment on or make changes to this bug.