413810 - There is a bug in function verify() in NativeFunction.h

Status: VERIFIED FIXED

(Tamarin Graveyard :: Virtual Machine, defect)

Description

[Leon Sha]

In function verify() when returnTraits() is NUMBER_TYPE or DOUBLE_TYPE, implvN should be assigned to implN. The return value of implvN is double while the return value of implv32 is Atom.

Comment 1

[Leon Sha]

Attachment: patch

Comment 2

[Tommy Reilly]

Did this cause a problem?  We've known about this for some time it just hasn't mattered so far so we haven't bothered to change it (preferring to find out if it mattered to some platform when and if that day comes).

Comment 3

[Leon Sha]

(In reply to comment #2)
> Did this cause a problem?  We've known about this for some time it just hasn't
> mattered so far so we haven't bothered to change it (preferring to find out if
> it mattered to some platform when and if that day comes).
> 

It did cause problem when we develop flash player on solaris. But I can't remember what is the problem. If you think it really need a test case, I'll try to find one.

Comment 4

[Leon Sha]

Without the patch there will be a lot of test case failed on sparc. For example e4x/Statements/e12_1.abc, e4x/XML/e13_4_4_2.abc, etc. With this patch these test will pass. Also this bug only happened on sparc. For x86, this is not a problem.

Comment 5

[Leon Sha]

Checked in.

Comment 6

[Chris Peyer]

Resolved fixed engineering / work item that has been pushed.  Setting status to
verified.