There is a bug in function verify() in NativeFunction.h

VERIFIED FIXED

Status

VERIFIED FIXED
11 years ago
9 years ago

People

(Reporter: leon.sha, Assigned: leon.sha)

Tracking

Details

Attachments

(1 attachment)

(Assignee)

Description

11 years ago
In function verify() when returnTraits() is NUMBER_TYPE or DOUBLE_TYPE, implvN should be assigned to implN. The return value of implvN is double while the return value of implv32 is Atom.
(Assignee)

Comment 1

11 years ago
Created attachment 298904 [details] [diff] [review]
patch
Attachment #298904 - Flags: review?(treilly)

Comment 2

11 years ago
Did this cause a problem?  We've known about this for some time it just hasn't mattered so far so we haven't bothered to change it (preferring to find out if it mattered to some platform when and if that day comes).
(Assignee)

Comment 3

11 years ago
(In reply to comment #2)
> Did this cause a problem?  We've known about this for some time it just hasn't
> mattered so far so we haven't bothered to change it (preferring to find out if
> it mattered to some platform when and if that day comes).
> 

It did cause problem when we develop flash player on solaris. But I can't remember what is the problem. If you think it really need a test case, I'll try to find one.
(Assignee)

Comment 4

11 years ago
Without the patch there will be a lot of test case failed on sparc. For example e4x/Statements/e12_1.abc, e4x/XML/e13_4_4_2.abc, etc. With this patch these test will pass. Also this bug only happened on sparc. For x86, this is not a problem.

Updated

11 years ago
Attachment #298904 - Flags: review?(treilly) → review+
(Assignee)

Comment 5

11 years ago
Checked in.
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED

Comment 6

9 years ago
Resolved fixed engineering / work item that has been pushed.  Setting status to
verified.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.