Closed Bug 413831 Opened 18 years ago Closed 17 years ago

nsCategoryManager::GetCategoryEntry returned is allocated via nsCRT::Strdup

Categories

(Core :: XPCOM, defect)

Product:
Core
Component:
XPCOM
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED DUPLICATE of bug 484309

People

(Reporter: dbradley, Assigned: dbradley)

Details

Attachments

(1 file)

Changes allocation of string to NS_strdup
568 bytes, patch
benjamin
: review+
Details | Diff | Splinter Review
It should use NS_strdup. This makes it impossible for applications using external linkage to properly match the allocation with the proper free.
Simple one liner fix
Assignee: nobody → dbradley
Status: NEW → ASSIGNED
Attachment #298931 - Flags: review?
Attachment #298931 - Flags: review? → review?(benjamin)
Attachment #298931 - Flags: review?(benjamin) → review+
Fixed in bug 484309.
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → DUPLICATE
Sorry for not spotting this bug (I searched Bugzilla for "mismatch"...)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: