Bugzilla::Template::quoteUrls should not quote non-ascii as URL

RESOLVED WONTFIX

Status

()

Bugzilla
User Interface
--
minor
RESOLVED WONTFIX
10 years ago
3 years ago

People

(Reporter: himorin, Assigned: himorin)

Tracking

Details

Attachments

(2 attachments, 1 obsolete attachment)

(Assignee)

Description

10 years ago
Created attachment 298936 [details]
Japanese text after http URL are quoted

Using bugzilla tip with utf8 = 1, all strings will be utf-8 flagged. So, all abbrs for regexp will be include > \u{FF}, like \w includes Japanese charactors.

Of cource, we might handle IDNs, but i think that should be an another bug.
(Assignee)

Comment 1

10 years ago
Created attachment 298937 [details] [diff] [review]
patch v1
Assignee: ui → shimono
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
(Assignee)

Comment 2

10 years ago
Created attachment 298944 [details] [diff] [review]
patch v2

merge the two codes (for non-utf8 and utf8) into one.
Attachment #298937 - Attachment is obsolete: true
Attachment #298944 - Flags: review?(myk)

Comment 3

10 years ago
Um, actually, there was another bug that pointed out that we *didn't* highlight i18n characters, for example for Russian Wikipedia.
Comment on attachment 298944 [details] [diff] [review]
patch v2

Canceling this review request, as I'm no longer able to do Bugzilla reviews.
Attachment #298944 - Flags: review?(myk)

Comment 5

3 years ago
Non ASCII characters are legal in URLs. I don't speak japanese, so I don't know why there is no whitespace after the end of the URL in your screenshot. But assuming this is a mistake of the commenter, there is no reason to catch that.
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.