413837 - Bugzilla::Template::quoteUrls should not quote non-ascii as URL

Status: RESOLVED WONTFIX

(Bugzilla :: User Interface, defect)

Description

[A. Shimono [:himorin]]

Attachment: Japanese text after http URL are quoted

Using bugzilla tip with utf8 = 1, all strings will be utf-8 flagged. So, all abbrs for regexp will be include > \u{FF}, like \w includes Japanese charactors.

Of cource, we might handle IDNs, but i think that should be an another bug.

Comment 1

[A. Shimono [:himorin]]

Attachment: patch v1

Comment 2

[A. Shimono [:himorin]]

Attachment: patch v2

merge the two codes (for non-utf8 and utf8) into one.

Comment 3

[Max Kanat-Alexander]

Um, actually, there was another bug that pointed out that we *didn't* highlight i18n characters, for example for Russian Wikipedia.

Comment 4

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 298944 [details] [diff] [review]
patch v2

Canceling this review request, as I'm no longer able to do Bugzilla reviews.

Comment 5

[Frédéric Buclin]

Non ASCII characters are legal in URLs. I don't speak japanese, so I don't know why there is no whitespace after the end of the URL in your screenshot. But assuming this is a mistake of the commenter, there is no reason to catch that.