413884 - The "Don't ask me again" checkbox in the "Unresponsive script" dialog does not have any access key

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[(no longer active)]

Attachment: Patch (v1)

Followup from bug 361170.

The "Don't ask me again" checkbox in the "Unresponsive script" dialog does not have any access key.

A simple patch to fix this is attached.  I've used an ampersand as the access key marker because that's what nsIPromptService expects.

Comment 1

[(no longer active)]

Since this may need to land before the l10n freeze, I'm asking for a quick review if possible.  Thanks!

Comment 2

[:Gijs (he/him)]

Shouldn't the buttons have access keys too, if this is really such an issue?

Comment 3

[(no longer active)]

(In reply to comment #2)
> Shouldn't the buttons have access keys too, if this is really such an issue?

They already have: Enter and Esc.

It's common not to include access keys for dialogs' default accept and cancel buttons.

Comment 4

[:Gijs (he/him)]

There's a third button in some cases, the debug one. I added it in bug 341764. I also posit that in the three-button dialog it is not clear which will be the default or cancel buttons. (heck, I could make that argument for the "Stop script" vs. "Continue script" buttons anyway)

Comment 5

[Johnny Stenback (:jst)]

Comment on attachment 298991 [details] [diff] [review]
Patch (v1)

r+sr=jst, but I don't think we'll get this into Firefox 3, our string freeze was tuesday, and only stuff that must be fixed should land now to ease the pain on our localizers.

Thanks for the patch! And if you disagree with the above, feel free to nominate this (blocking1.9?) and we'll reconsider...

Comment 6

[:Gijs (he/him)]

jst: Actually, the string freeze was moved, per http://developer.mozilla.org/devnews/index.php/2008/01/22/firefox-3-string-freeze-this-friday-january-25th-at-1159pm-pst/

So this should be clear to land still, I think - assuming it gets approval?

Comment 7

[(no longer active)]

Comment on attachment 298991 [details] [diff] [review]
Patch (v1)

Seeking approval.  Minimal change here, needs to land before the l10n freeze.

Comment 8

[(no longer active)]

(In reply to comment #6)
> So this should be clear to land still, I think - assuming it gets approval?

Yes, it should...

Comment 9

[Reed Loden [:reed]]

Checking in dom/locales/en-US/chrome/dom/dom.properties;
/cvsroot/mozilla/dom/locales/en-US/chrome/dom/dom.properties,v  <--  dom.properties
new revision: 1.11; previous revision: 1.10
done