413900 - nsLoadCollector "Couldn't get document"

Status: RESOLVED INCOMPLETE

(Toolkit Graveyard :: Data Collection/Metrics, defect)

Description

[Alex Polvi]

The nsLoadCollector is broken. It is no longer recording <document /> elements. 

Some example debugging output:

-1610559488[507180]: LoadCollector: progress = 13e5e5f4, request = 13a94c9c [http://mxr.mozilla.org/seamonkey/search?find=%2Fextensions%2Fmetrics%2Fsrc%2F&string=t+get+document], flags = 10f0001, status = 0
-1610559488[507180]: LoadCollector: progress = 13e5e5f4, request = 13a94c9c [http://mxr.mozilla.org/seamonkey/search?find=%2Fextensions%2Fmetrics%2Fsrc%2F&string=t+get+document], flags = 1030004, status = 0
-1610559488[507180]: LoadCollector: progress = 13e5e5f4, request = 13a94c9c [http://mxr.mozilla.org/seamonkey/search?find=%2Fextensions%2Fmetrics%2Fsrc%2F&string=t+get+document], flags = 1020010, status = 0
-1610559488[507180]: Couldn't get document
-1610559488[507180]: LoadCollector: progress = 13e5e5f4, request = 1481d1fc [http://mxr.mozilla.org/seamonkey/source/extensions/metrics/src/nsLoadCollector.cpp], flags = f0001, status = 0
-1610559488[507180]: LoadCollector: progress = 13e5e5f4, request = 1481d1fc [http://mxr.mozilla.org/seamonkey/source/extensions/metrics/src/nsLoadCollector.cpp], flags = 30004, status = 0
-1610559488[507180]: LoadCollector: progress = 13e5e5f4, request = 1481d1fc [http://mxr.mozilla.org/seamonkey/source/extensions/metrics/src/nsLoadCollector.cpp], flags = 20010, status = 0
-1610559488[507180]: Couldn't get document

Comment 1

[Alex Polvi]

Also, if possible, we should add a unit test to make sure this is still working.

Comment 2

[Pete Collins (MDG)]

Ok, in my build I am not seeing any issues. I am running off a trunk build from about a week and a half ago.

I'll sync and then try to reproduce again.

Comment 3

[Pete Collins (MDG)]

Attachment: metrics XML file

I created a new profile and testing using a freshly synced trunk, I can't seem to reproduce.

Comment 4

[Pete Collins (MDG)]

Attachment: Metrics PR Log

Here is my PR Log

Comment 5

[Pete Collins (MDG)]

Alex, can you provide more detail about the build of metrics you are testing?

Is it the last build of XPI binaries?

Comment 6

[Alex Polvi]

(In reply to comment #5)
> Alex, can you provide more detail about the build of metrics you are testing?
> 
> Is it the last build of XPI binaries?

Yep, v2a3 on Mac OS X.

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9b3pre) Gecko/2008012704 Minefield/3.0b3pre

Comment 7

[Alex Polvi]

fixed with latest version

Comment 8

[Alex Polvi]

Seeing this again. 

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9b5pre) Gecko/2008031804 Minefield/3.0b5pre

Spectator version 2a5

Trunk must have moved. 

Comment 9

[Pete Collins (MDG)]

Last version I posted should be 2a6 ...

Are you sure you are testing the correct XPI?

Comment 10

[Alex Polvi]

(In reply to comment #9)
> Last version I posted should be 2a6 ...
> 
> Are you sure you are testing the correct XPI?
> 

I was using 2a5! Whoops! Works fine now. 

Comment 11

[Alex Polvi]

seeing this on 3.0pre when using 2a6... 

Comment 12

[Pete Collins (MDG)]

Alex, BTW 2a7 is posted win32 and OSX. had some Linux bustage I need to resolve.

Comment 13

[Pete Collins (MDG)]

using 2a7 it works fine for me on 3.0pre

I'll try updating to a nightly.

Comment 14

[Pete Collins (MDG)]

Ah, ok it's failing after I upgraded to a nightly.

-1610559488[5071d0]: Couldn't get document

But I thought we were only targeting Beta release builds?

Should I spin off some new builds?

Comment 15

[Alex Polvi]

(In reply to comment #14)
> Ah, ok it's failing after I upgraded to a nightly.
> 
> -1610559488[5071d0]: Couldn't get document
> 
> But I thought we were only targeting Beta release builds?

Indeed -- but I could not get it to work with beta 5 on Mac 10.4. Does it work for you?

Comment 16

[Pete Collins (MDG)]

I'll go install beta 5 just to be sure. Yes I'm on Mac 10.4.x

Comment 17

[Pete Collins (MDG)]

Ok, yes I ma seeing the problem on beta 5 as well.

I will checkout and build that tag specifically and respin the XPI's.