Closed
Bug 413913
Opened 16 years ago
Closed 16 years ago
fix for failure to catch chmod exception in ffprofile_win32
Categories
(Release Engineering :: General, defect)
Tracking
(Not tracked)
RESOLVED
WORKSFORME
People
(Reporter: anodelman, Assigned: anodelman)
Details
Attachments
(2 files)
1.21 KB,
patch
|
rcampbell
:
review+
|
Details | Diff | Splinter Review |
1.55 KB,
patch
|
rcampbell
:
review+
|
Details | Diff | Splinter Review |
The same fix was checked in for mac/linux, but didn't make it over to the win side of the world.
Attachment #299036 -
Flags: review?(rcampbell)
Comment 1•16 years ago
|
||
Comment on attachment 299036 [details] [diff] [review] catch exceptions generated during chmod *rubberstamped*
Attachment #299036 -
Flags: review?(rcampbell) → review+
Assignee | ||
Comment 2•16 years ago
|
||
Checking in ffprofile_win32.py; /cvsroot/mozilla/testing/performance/talos/ffprofile_win32.py,v <-- ffprofile_win32.py new revision: 1.2; previous revision: 1.1 done
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 3•16 years ago
|
||
That first patch was helpful, but it just pushed the crash out to the attempt to remove the file in question. Hopefully this will normalize the file attributes and fix the problem.
Assignee: nobody → anodelman
Status: RESOLVED → ASSIGNED
Attachment #299049 -
Flags: review?(rcampbell)
Resolution: FIXED → ---
Updated•16 years ago
|
Attachment #299049 -
Flags: review?(rcampbell) → review+
Assignee | ||
Comment 4•16 years ago
|
||
The second patch isn't needed as the actual problem was in the pageloader. Going to mark this WORKSFORME, since the problem wasn't in the talos code.
Status: ASSIGNED → RESOLVED
Closed: 16 years ago → 16 years ago
Resolution: --- → WORKSFORME
Comment 5•16 years ago
|
||
Mass move of Core:Testing bugs to mozilla.org:Release Engineering:Talos. Filter on RelEngTalosMassMove to ignore.
Component: Testing → Release Engineering: Talos
Product: Core → mozilla.org
QA Contact: testing → release
Version: unspecified → other
Updated•11 years ago
|
Product: mozilla.org → Release Engineering
You need to log in
before you can comment on or make changes to this bug.
Description
•