413944 - backup frecency data for the top-ranking URIs

Status: RESOLVED INACTIVE

(Firefox :: Bookmarks & History, defect)

Description

[Seth Spitzer]

in our json file, also write out top <n> most frecent places

when bug #384370 lands, we'll have our bookmarks on disk in .json format.

with the larger history default and the url bar autocomplete, I find myself bookmarking less, and instead relying on url bar autocomplete.

in the scenarios where places.sqlite was corrupted, or a schema changed, or whatever else people might use the .json for, what about writing out the top <n> most frecent places as well?

based on the patch in bug #394038, we might also have to write out the  <places.frecency.numVisits> most recent visits for each of the places we write out.

that way (after import) when we next attempt to recalculate the frecency for one of those places (on idle or upon visit), our calculation is correct (as we use the places.frecency.numVisits most recent visits to determine the frecency.)

if we don't have any visits, we run the risk of expiring the moz_place.

dietrich, what do you think?

Comment 1

[Dietrich Ayala (:dietrich)]

generalizing this to cover backup and restore of frecency for all bookmarks. once frecency value is exposed in result nodes, fixing this bug is not a big deal.

Comment 2

[Seth Spitzer]

to clarify:  this was not about bookmarks, but about non-bookmarked places.

I don't have too many bookmarks, but I have lots of places with frecency that I'd like to get on restore.

see also my note in comment #0 about writing out and restoring the most recent visits.

or, did I misunderstand your intent when you changed the summary of this bug?

Comment 3

[Dietrich Ayala (:dietrich)]

oops, i meant that we could also hang this data off of the backed-up bookmarks as well, but i'll file a separate bug for that. i re-shuffled the summary to reflect the original intent.

Comment 4

[Dietrich Ayala (:dietrich)]

(In reply to comment #3)
> i'll file a separate bug for that. 

bug 437306 for bookmarks

Comment 5

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv

Comment 6

[BMO Automation]

Per policy at https://wiki.mozilla.org/Bug_Triage/Projects/Bug_Handling/Bug_Husbandry#Inactive_Bugs. If this bug is not an enhancement request or a bug not present in a supported release of Firefox, then it may be reopened.