413963 - Password manager has unsafe dependency on browser

Status: RESOLVED FIXED

(Toolkit :: Password Manager, defect)

Description

[[e-mail]]

Even Bugzilla thinks that the password, or should I call it login, manager is a browser component, although in CVS it lives in toolkit and there is work to get Thunderbird and SeaMonkey working with it. Unfortunately it makes assumptions about its consumers. These assumptions should be moved to notification.xml where anyone can use them.

Comment 1

[[e-mail]]

Attachment: Possible patch

If you tweak a SeaMonkey tree to build login manager then this works as expected.

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 299157 [details] [diff] [review]
Possible patch

This looks mostly fine, but the currentNotification handling in removeTransientNotifications needs to be fixed as discussed on IRC.

Comment 3

[[e-mail]]

Attachment: Lazy patch

This just removes the aImmediate parameter.

Comment 4

[[e-mail]]

Attachment: Alternative patch

The idea of this patch is that you can remove all the notifications immediately but only if they are all transient. Otherwise they slide out.

Comment 5

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 299402 [details] [diff] [review]
Lazy patch

I think I prefer this one, we can support an "immediate" parameter if the need arises at some point in the future.

Comment 6

[[e-mail]]

Comment on attachment 299402 [details] [diff] [review]
Lazy patch

API cleanup.

Comment 7

[Damon Sicore (:damons)]

Comment on attachment 299402 [details] [diff] [review]
Lazy patch

a1.9+=damons

Comment 8

[[e-mail]]

Fix checked in.

Comment 9

[:Gijs (he/him)]

Unsetting flag seeing as this is checked in...