Changes to get sampling working in tamarin

VERIFIED FIXED

Status

Tamarin
Virtual Machine
VERIFIED FIXED
10 years ago
8 years ago

People

(Reporter: Erik Tierney, Unassigned)

Tracking

Details

Attachments

(1 attachment)

(Reporter)

Description

10 years ago
Created attachment 299232 [details] [diff] [review]
implements changes described in bug

Changes to get the sampling API working in tc.  Before calls to the sampling methods would crash.

Had to add a ShellToplevel class to keep track of the builtin shell classes.  Before we were using the Toplevel from avmplus, but it didn't know anything about the shell classes.

Also had to regenerate toplevel.h due to an asc bug that generated the wring indexes for abcpackage_ constants.  This was causing the wrong script to get marked as a native script, so the sampler init code never got run.
Attachment #299232 - Flags: review?(treilly)

Updated

10 years ago
Attachment #299232 - Flags: review?(treilly) → review+

Updated

10 years ago
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED

Comment 2

8 years ago
Resolved fixed engineering / work item that has been pushed.  Setting status to verified.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.