414046 - nsPresShell::GetLayoutObjectFor() should be removed

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Aaron Leventhal]

There is no need for it -- it's redundant with GetPrimaryFrameFor(), and GetPrimaryFrameFor() is more convenient since it returns the frame (instead of using an out param).

Comment 1

[Arpad Borsos [:Swatinem]]

Attachment: patch

I pushed the QI logic to the only 2 callers, I'm not sure it's still needed though.

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

It's not needed, just return the frame directly. Maybe add an NS_ASSERTION that the QI returns the same pointer value as the frame.

And rev the IID on nsIPresShell.

Comment 3

[Arpad Borsos [:Swatinem]]

Attachment: v2

I hope this is right. At least the compiler doesn't complain about it. :D
Hm the only 2 users of the http://mxr.mozilla.org/mozilla-central/ident?i=GetLayoutObject methods I found were in http://mxr.mozilla.org/mozilla-central/source/editor/libeditor/html/nsTableEditor.cpp#2722
Maybe it would be an idea to push the code even further up the call chain?

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Yeah, let's do that!

Comment 5

[Arpad Borsos [:Swatinem]]

Attachment: v3

This patch gets rid of both GetLayoutObject methods and moves the code up to nsHTMLEditor::GetCellIndexes and nsHTMLEditor::GetTableLayoutObject which are defined in nsTableEditor.cpp.
I left the QI parts in as they cast the frame to nsITableCellLayout or nsITableLayout respectively.

Comment 6

[Frank Wein [:mcsmurf]]

Pushed to mozilla-central, changeset 5abe5d840c95.