414074 - cache the results of a safebrowsing gethash response

Status: RESOLVED FIXED

(Toolkit :: Safe Browsing, defect, P1)

Description

[Dave Camp (:dcamp)]

We should be caching the results of a gethash response.

Comment 1

[Dave Camp (:dcamp)]

Attachment: v1

... like so.

Comment 2

[Tony Chang (Google)]

Comment on attachment 299347 [details] [diff] [review]
v1

Rather than having the GetWorkerProxy method and exposing the implementation details, can we instead add CacheCompletions to nsUrlClassifierDBService that forwards on the call to the worker proxy?

Other than that, this looks fine.

Comment 3

[Dave Camp (:dcamp)]

Attachment: v2

Fixes for review comments.

Comment 4

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 299472 [details] [diff] [review]
v2

a=beltzner

Comment 5

[Dave Camp (:dcamp)]

We shouldn't land the new protocol without landing this patch soon after, so I'm bumping to P1 and adding the beta 3 milestone.

Comment 6

[Dave Camp (:dcamp)]

Checking in public/nsIUrlClassifierDBService.idl;
/cvsroot/mozilla/toolkit/components/url-classifier/public/nsIUrlClassifierDBService.idl,v  <--  nsIUrlClassifierDBService.idl
new revision: 1.19; previous revision: 1.18
done
Checking in src/nsUrlClassifierDBService.cpp;
/cvsroot/mozilla/toolkit/components/url-classifier/src/nsUrlClassifierDBService.cpp,v  <--  nsUrlClassifierDBService.cpp
new revision: 1.57; previous revision: 1.56
done
Checking in src/nsUrlClassifierDBService.h;
/cvsroot/mozilla/toolkit/components/url-classifier/src/nsUrlClassifierDBService.h,v  <--  nsUrlClassifierDBService.h
new revision: 1.12; previous revision: 1.11
done
Checking in tests/unit/test_partial.js;
/cvsroot/mozilla/toolkit/components/url-classifier/tests/unit/test_partial.js,v  <--  test_partial.js
new revision: 1.4; previous revision: 1.3
done