cache the results of a safebrowsing gethash response

RESOLVED FIXED in Firefox 3 beta3

Status

()

P1
normal
RESOLVED FIXED
11 years ago
4 years ago

People

(Reporter: dcamp, Assigned: dcamp)

Tracking

unspecified
Firefox 3 beta3
Points:
---
Bug Flags:
blocking-firefox3 +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

v2
15.27 KB, patch
beltzner
: approval1.9+
Details | Diff | Splinter Review
(Assignee)

Description

11 years ago
We should be caching the results of a gethash response.
Flags: blocking-firefox3?
(Assignee)

Comment 1

11 years ago
Created attachment 299347 [details] [diff] [review]
v1

... like so.
Assignee: nobody → dcamp
Status: NEW → ASSIGNED
Attachment #299347 - Flags: review?(tony)

Comment 2

11 years ago
Comment on attachment 299347 [details] [diff] [review]
v1

Rather than having the GetWorkerProxy method and exposing the implementation details, can we instead add CacheCompletions to nsUrlClassifierDBService that forwards on the call to the worker proxy?

Other than that, this looks fine.
Attachment #299347 - Flags: review?(tony) → review+
(Assignee)

Comment 3

11 years ago
Created attachment 299472 [details] [diff] [review]
v2

Fixes for review comments.
Attachment #299347 - Attachment is obsolete: true
Attachment #299472 - Flags: approval1.9?
Flags: blocking-firefox3? → blocking-firefox3+
Priority: -- → P2
Comment on attachment 299472 [details] [diff] [review]
v2

a=beltzner
Attachment #299472 - Flags: approval1.9? → approval1.9+
(Assignee)

Comment 5

11 years ago
We shouldn't land the new protocol without landing this patch soon after, so I'm bumping to P1 and adding the beta 3 milestone.
Priority: P2 → P1
Target Milestone: --- → Firefox 3 beta3
(Assignee)

Comment 6

11 years ago
Checking in public/nsIUrlClassifierDBService.idl;
/cvsroot/mozilla/toolkit/components/url-classifier/public/nsIUrlClassifierDBService.idl,v  <--  nsIUrlClassifierDBService.idl
new revision: 1.19; previous revision: 1.18
done
Checking in src/nsUrlClassifierDBService.cpp;
/cvsroot/mozilla/toolkit/components/url-classifier/src/nsUrlClassifierDBService.cpp,v  <--  nsUrlClassifierDBService.cpp
new revision: 1.57; previous revision: 1.56
done
Checking in src/nsUrlClassifierDBService.h;
/cvsroot/mozilla/toolkit/components/url-classifier/src/nsUrlClassifierDBService.h,v  <--  nsUrlClassifierDBService.h
new revision: 1.12; previous revision: 1.11
done
Checking in tests/unit/test_partial.js;
/cvsroot/mozilla/toolkit/components/url-classifier/tests/unit/test_partial.js,v  <--  test_partial.js
new revision: 1.4; previous revision: 1.3
done
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
(Assignee)

Updated

11 years ago
Depends on: 402611
Component: Phishing Protection → Phishing Protection
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.