Closed Bug 414074 Opened 14 years ago Closed 14 years ago

cache the results of a safebrowsing gethash response

Categories

(Toolkit :: Safe Browsing, defect, P1)

defect

Tracking

()

RESOLVED FIXED
Firefox 3 beta3

People

(Reporter: dcamp, Assigned: dcamp)

References

Details

Attachments

(1 file, 1 obsolete file)

We should be caching the results of a gethash response.
Flags: blocking-firefox3?
Attached patch v1 (obsolete) — Splinter Review
... like so.
Assignee: nobody → dcamp
Status: NEW → ASSIGNED
Attachment #299347 - Flags: review?(tony)
Comment on attachment 299347 [details] [diff] [review]
v1

Rather than having the GetWorkerProxy method and exposing the implementation details, can we instead add CacheCompletions to nsUrlClassifierDBService that forwards on the call to the worker proxy?

Other than that, this looks fine.
Attachment #299347 - Flags: review?(tony) → review+
Attached patch v2Splinter Review
Fixes for review comments.
Attachment #299347 - Attachment is obsolete: true
Attachment #299472 - Flags: approval1.9?
Flags: blocking-firefox3? → blocking-firefox3+
Priority: -- → P2
Comment on attachment 299472 [details] [diff] [review]
v2

a=beltzner
Attachment #299472 - Flags: approval1.9? → approval1.9+
We shouldn't land the new protocol without landing this patch soon after, so I'm bumping to P1 and adding the beta 3 milestone.
Priority: P2 → P1
Target Milestone: --- → Firefox 3 beta3
Checking in public/nsIUrlClassifierDBService.idl;
/cvsroot/mozilla/toolkit/components/url-classifier/public/nsIUrlClassifierDBService.idl,v  <--  nsIUrlClassifierDBService.idl
new revision: 1.19; previous revision: 1.18
done
Checking in src/nsUrlClassifierDBService.cpp;
/cvsroot/mozilla/toolkit/components/url-classifier/src/nsUrlClassifierDBService.cpp,v  <--  nsUrlClassifierDBService.cpp
new revision: 1.57; previous revision: 1.56
done
Checking in src/nsUrlClassifierDBService.h;
/cvsroot/mozilla/toolkit/components/url-classifier/src/nsUrlClassifierDBService.h,v  <--  nsUrlClassifierDBService.h
new revision: 1.12; previous revision: 1.11
done
Checking in tests/unit/test_partial.js;
/cvsroot/mozilla/toolkit/components/url-classifier/tests/unit/test_partial.js,v  <--  test_partial.js
new revision: 1.4; previous revision: 1.3
done
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Depends on: 402611
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.