If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

PluralForm messages show up in Error Console when downloading

VERIFIED FIXED in mozilla1.9beta3

Status

()

Toolkit
Downloads API
VERIFIED FIXED
10 years ago
9 years ago

People

(Reporter: Mardak, Assigned: Mardak)

Tracking

Trunk
mozilla1.9beta3
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

v1
808 bytes, patch
sdwilsh
: review+
Mike Schroepfer
: approval1.9+
Details | Diff | Splinter Review
(Assignee)

Description

10 years ago
We're calling PluralForm.get with a string that we don't care about when trying to get a sub-unit below "seconds".
(Assignee)

Comment 1

10 years ago
Created attachment 299391 [details] [diff] [review]
v1
Assignee: nobody → edilee
Status: NEW → ASSIGNED
Attachment #299391 - Flags: review?(sdwilsh)
(Assignee)

Comment 2

10 years ago
The return value of PluralForm.get is also the empty string, so functionally, there's no difference. This fix just avoids the messages from showing up unnecessarily.
Flags: in-testsuite-
Comment on attachment 299391 [details] [diff] [review]
v1

r=sdwilsh
Attachment #299391 - Flags: review?(sdwilsh)
Attachment #299391 - Flags: review+
Attachment #299391 - Flags: approval1.9?

Updated

10 years ago
Attachment #299391 - Flags: approval1.9? → approval1.9+

Updated

10 years ago
Keywords: late-l10n
(Assignee)

Comment 4

10 years ago
There aren't any string changes here. Does it still need the l10n-late?

Comment 5

10 years ago
Nope - wrong bug.
Keywords: late-l10n
(Assignee)

Comment 6

10 years ago
Checking in toolkit/mozapps/downloads/src/DownloadUtils.jsm;
/cvsroot/mozilla/toolkit/mozapps/downloads/src/DownloadUtils.jsm,v  <--  DownloadUtils.jsm
new revision: 1.3; previous revision: 1.2
done
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3 M11
Verified; not seeing these.
Status: RESOLVED → VERIFIED
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.