Closed
Bug 414105
Opened 16 years ago
Closed 16 years ago
PluralForm messages show up in Error Console when downloading
Categories
(Toolkit :: Downloads API, defect)
Toolkit
Downloads API
Tracking
()
VERIFIED
FIXED
mozilla1.9beta3
People
(Reporter: Mardak, Assigned: Mardak)
Details
Attachments
(1 file)
808 bytes,
patch
|
sdwilsh
:
review+
mtschrep
:
approval1.9+
|
Details | Diff | Splinter Review |
We're calling PluralForm.get with a string that we don't care about when trying to get a sub-unit below "seconds".
Assignee | ||
Comment 1•16 years ago
|
||
Assignee | ||
Comment 2•16 years ago
|
||
The return value of PluralForm.get is also the empty string, so functionally, there's no difference. This fix just avoids the messages from showing up unnecessarily.
Flags: in-testsuite-
Comment 3•16 years ago
|
||
Comment on attachment 299391 [details] [diff] [review] v1 r=sdwilsh
Attachment #299391 -
Flags: review?(sdwilsh)
Attachment #299391 -
Flags: review+
Attachment #299391 -
Flags: approval1.9?
Updated•16 years ago
|
Attachment #299391 -
Flags: approval1.9? → approval1.9+
Assignee | ||
Comment 4•16 years ago
|
||
There aren't any string changes here. Does it still need the l10n-late?
Assignee | ||
Comment 6•16 years ago
|
||
Checking in toolkit/mozapps/downloads/src/DownloadUtils.jsm; /cvsroot/mozilla/toolkit/mozapps/downloads/src/DownloadUtils.jsm,v <-- DownloadUtils.jsm new revision: 1.3; previous revision: 1.2 done
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3 M11
Updated•16 years ago
|
Product: Firefox → Toolkit
You need to log in
before you can comment on or make changes to this bug.
Description
•