414120 - Update Basque Wikipedia search plugin to support suggestions

Status: RESOLVED FIXED

(Mozilla Localizations :: eu / Basque, defect)

Description

[Julen Ruiz Aizpuru]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; eu; rv:1.9b3pre) Gecko/2008012404 Minefield/3.0b3pre
Build Identifier: 

Update of the Basque Wikipedia search plugin to add suggestions feature.

Reference: bug 412176

Reproducible: Always

Comment 1

[Julen Ruiz Aizpuru]

Attachment: wikipedia-eu patch

Comment 2

[Axel Hecht [:Pike]]

Comment on attachment 299410 [details] [diff] [review]
wikipedia-eu patch

We're making a bunch of further improvements to the wikipedia plugins across the board, we should get those in for Basque, too.

http://mxr.mozilla.org/l10n/source/it/browser/searchplugins/wikipedia-it.xml is a good example of what the plugin should look like. <ShortName> should be "Wikipedia (Euskara)", and the template the the SearchForm should be http://eu.wikipedia.org/wiki/Aparteko:Search.

Mind doing another patch for that?

Comment 3

[Julen Ruiz Aizpuru]

Attachment: updated wikipedia-eu patch

Updated patch correcting the mentioned strings.

Comment 4

[Axel Hecht [:Pike]]

Comment on attachment 300097 [details] [diff] [review]
updated wikipedia-eu patch

r=me, please check in with a comment referencing this bug and my review, something like "bug 414120, update wikipedia search plugin, add search suggest, r=[e-mail]" would work.

Comment 5

[Axel Hecht [:Pike]]

Julen, if you check in a patch that fixes a bug, please resolve the bug FIXED.

I checked, you didn't have permissions to do that, so I fixed that. So from now, you can mark bugs fixed, reassign them etc. Please use your powers carefully.