414203 - Download statusbar tooltip says "Double click to open..." but single click works

Status: VERIFIED FIXED

(Toolkit :: Downloads API, defect)

Description

[Steve England [:stevee]]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b3pre) Gecko/2008012700 Minefield/3.0b3pre ID:2008012700

If you hover over the download activity indicator in the status bar it says "Double click to open downloads window" but in fact it seems a single click suffices.

Comment 1

[Ed Lee :Mardak]

Attachment: v1

Have both single click and double click work.. and let users know with a better tooltip.

Comment 2

[Asaf Romano (gone)]

Er, why do we need the dblclick handler then?

Comment 3

[Ed Lee :Mardak]

I was hoping you knew! :) Will the dblclick handler consume the double click and treat it as one event instead of two separate events?

Comment 4

[Ed Lee :Mardak]

Attachment: v1.1

Totally not what I was expecting.
<button label="0" oncommand="this.label=Number(this.label)+1" ondblclick="doCommand()"/>

double click -> 2 clicks plus a double click = 3 commands triggered

But I suppose it makes some kind of sense..

Comment 5

[Asaf Romano (gone)]

Comment on attachment 299624 [details] [diff] [review]
v1.1

r=mano

Comment 6

[Ed Lee :Mardak]

Comment on attachment 299624 [details] [diff] [review]
v1.1

Has a (simple) string change so l10n-late a?

Comment 7

[Damon Sicore (:damons)]

Comment on attachment 299624 [details] [diff] [review]
v1.1

a1.9+=damons

Comment 8

[Ed Lee :Mardak]

Checking in browser/base/content/browser.xul;
/cvsroot/mozilla/browser/base/content/browser.xul,v  <--  browser.xul
new revision: 1.409; previous revision: 1.408
done
Checking in browser/locales/en-US/chrome/browser/browser.dtd;
/cvsroot/mozilla/browser/locales/en-US/chrome/browser/browser.dtd,v  <--  browser.dtd
new revision: 1.94; previous revision: 1.93
done

Comment 9

[Stephen Donner [:stephend] Not actively reading bugmail]

https://litmus.mozilla.org/show_test.cgi?id=5163

in-litmus+

Comment 10

[Marcia Knous [:marcia]]

I ran the test case stephend created in Comment 9 to verify this but I came up with different behavior on different operating systems. On Mac if I click the status bar while an active download is happening, it opens the status bar. If I click again the DM dialog goes away. On Win Vista, clicking on the status bar notification again does not dismiss the DM window. I am not sure what the expected behavior should be here but wanted to note this behavior.

Comment 11

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to comment #10)
> I ran the test case stephend created in Comment 9 to verify this but I came up
> with different behavior on different operating systems. On Mac if I click the
> status bar while an active download is happening, it opens the status bar. If I
> click again the DM dialog goes away. On Win Vista, clicking on the status bar
> notification again does not dismiss the DM window. I am not sure what the
> expected behavior should be here but wanted to note this behavior.

We'll have to spin that one off; this is literally just a string fix.

Verified FIXED using:

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9b3pre) Gecko/2008020104 Minefield/3.0b3pre

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9b3pre) Gecko/2008020104 Minefield/3.0b3pre

-and-

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b3pre) Gecko/2008020104 Minefield/3.0b3pre