Closed Bug 414203 Opened 13 years ago Closed 13 years ago

Download statusbar tooltip says "Double click to open..." but single click works

Categories

(Toolkit :: Downloads API, defect)

defect
Not set
trivial

Tracking

()

VERIFIED FIXED
mozilla1.9beta3

People

(Reporter: stevee, Assigned: Mardak)

References

Details

(Keywords: late-l10n)

Attachments

(1 file, 1 obsolete file)

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b3pre) Gecko/2008012700 Minefield/3.0b3pre ID:2008012700

If you hover over the download activity indicator in the status bar it says "Double click to open downloads window" but in fact it seems a single click suffices.
Flags: blocking-firefox3?
OS: Windows XP → All
Hardware: PC → All
Attached patch v1 (obsolete) — Splinter Review
Have both single click and double click work.. and let users know with a better tooltip.
Assignee: nobody → edilee
Status: NEW → ASSIGNED
Attachment #299587 - Flags: review?(mano)
Er, why do we need the dblclick handler then?
I was hoping you knew! :) Will the dblclick handler consume the double click and treat it as one event instead of two separate events?
Attached patch v1.1Splinter Review
Totally not what I was expecting.
<button label="0" oncommand="this.label=Number(this.label)+1" ondblclick="doCommand()"/>

double click -> 2 clicks plus a double click = 3 commands triggered

But I suppose it makes some kind of sense..
Attachment #299587 - Attachment is obsolete: true
Attachment #299624 - Flags: review?(mano)
Attachment #299587 - Flags: review?(mano)
Comment on attachment 299624 [details] [diff] [review]
v1.1

Has a (simple) string change so l10n-late a?
Attachment #299624 - Flags: approval1.9?
Comment on attachment 299624 [details] [diff] [review]
v1.1

a1.9+=damons
Attachment #299624 - Flags: approval1.9? → approval1.9+
Checking in browser/base/content/browser.xul;
/cvsroot/mozilla/browser/base/content/browser.xul,v  <--  browser.xul
new revision: 1.409; previous revision: 1.408
done
Checking in browser/locales/en-US/chrome/browser/browser.dtd;
/cvsroot/mozilla/browser/locales/en-US/chrome/browser/browser.dtd,v  <--  browser.dtd
new revision: 1.94; previous revision: 1.93
done
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Flags: in-litmus?
Keywords: late-l10n
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3 M11
I ran the test case stephend created in Comment 9 to verify this but I came up with different behavior on different operating systems. On Mac if I click the status bar while an active download is happening, it opens the status bar. If I click again the DM dialog goes away. On Win Vista, clicking on the status bar notification again does not dismiss the DM window. I am not sure what the expected behavior should be here but wanted to note this behavior.
(In reply to comment #10)
> I ran the test case stephend created in Comment 9 to verify this but I came up
> with different behavior on different operating systems. On Mac if I click the
> status bar while an active download is happening, it opens the status bar. If I
> click again the DM dialog goes away. On Win Vista, clicking on the status bar
> notification again does not dismiss the DM window. I am not sure what the
> expected behavior should be here but wanted to note this behavior.

We'll have to spin that one off; this is literally just a string fix.

Verified FIXED using:

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9b3pre) Gecko/2008020104 Minefield/3.0b3pre

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9b3pre) Gecko/2008020104 Minefield/3.0b3pre

-and-

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b3pre) Gecko/2008020104 Minefield/3.0b3pre
Status: RESOLVED → VERIFIED
Flags: blocking-firefox3?
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.