show bug UI broken after editing an attachment

RESOLVED FIXED in Bugzilla 3.2

Status

()

Bugzilla
User Interface
--
major
RESOLVED FIXED
10 years ago
10 years ago

People

(Reporter: Frédéric Buclin, Assigned: Guy Pyrzak)

Tracking

(Blocks: 1 bug, {regression})

3.1.2
Bugzilla 3.2
regression
Dependency tree / graph
Bug Flags:
approval +
blocking3.1.3 +

Details

Attachments

(2 attachments, 1 obsolete attachment)

(Reporter)

Description

10 years ago
Edit an attachment, the next page has a broken UI. Probably a missing CSS or JS file somewhere.
Flags: blocking3.1.3+
(Assignee)

Comment 1

10 years ago
caused by missing the JS and CSS in the header file. Easy fix
Status: NEW → ASSIGNED
(Assignee)

Comment 2

10 years ago
Created attachment 299632 [details] [diff] [review]
Patch V1

basically this page is used to display bug/show.html.tmpl and was missing all the stuff that is the header for show.html.tmpl. This fixes a LOT of bugs(including for keywords and the calendar working.
Attachment #299632 - Flags: review?(mkanat)
(Assignee)

Comment 3

10 years ago
Created attachment 299633 [details] [diff] [review]
Patch V2

Fixed the indentation, Thanks Lp
Attachment #299632 - Attachment is obsolete: true
Attachment #299633 - Flags: review?(mkanat)
Attachment #299632 - Flags: review?(mkanat)

Comment 4

10 years ago
Comment on attachment 299633 [details] [diff] [review]
Patch V2

This is good, but can we create a variable called show_bug or something for the header that will automatically just include all of this stuff? We're going to be modifying this a lot, particularly with YUI, and I don't want to have to remember everywhere it's supposed to be.
(Assignee)

Comment 5

10 years ago
Comment on attachment 299633 [details] [diff] [review]
Patch V2

I can comment without being logged in?
(Reporter)

Comment 6

10 years ago
(In reply to comment #5)
> (From update of attachment 299633 [details] [diff] [review])
> I can comment without being logged in?
> 

No you cannot. The textarea is not displayed.
(Reporter)

Comment 7

10 years ago
Oh wait, you mean from the "edit attachment" page? Yes, the comment field is available. On submit, Bugzilla will ask you to authenticate.
(Assignee)

Comment 8

10 years ago
(In reply to comment #4)
> (From update of attachment 299633 [details] [diff] [review])
> This is good, but can we create a variable called show_bug or something for the
> header that will automatically just include all of this stuff? We're going to
> be modifying this a lot, particularly with YUI, and I don't want to have to
> remember everywhere it's supposed to be.
> 

I agree. But that's a separate bug/enhancement. This fixes the problem. I know all the files that need to be edited. If you don't mind Max, file the bug and assign it to me.
(Assignee)

Comment 9

10 years ago
Created attachment 300050 [details]
Screen shot of changes
(Reporter)

Comment 10

10 years ago
Comment on attachment 299633 [details] [diff] [review]
Patch V2

We really need to refactor this to avoid this duplicated code. But I agree that's a separate bug. So r=LpSolit for now (I will open a separate bug to refactor this).
Attachment #299633 - Flags: review?(mkanat) → review+
(Reporter)

Updated

10 years ago
Flags: approval+
(Reporter)

Comment 11

10 years ago
Checking in template/en/default/attachment/updated.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/attachment/updated.html.tmpl,v  <--  updated.html.tmpl
new revision: 1.17; previous revision: 1.16
done
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
(Assignee)

Updated

10 years ago
Blocks: 415819
You need to log in before you can comment on or make changes to this bug.